Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jul 2012 00:52:37 +0800
From:      Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Carlo Strub <cs@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r301663 - in head: editors/aewan games/BillardGL games/apoolGL games/ctris games/deng games/el-data games/flightgear-data games/foobillard games/memonix games/plonx games/tremulous game...
Message-ID:  <CAMHz58QDmJQ6W6euUWw6bHvTFyXTgrcjyLxBCcaO5f1%2BNYHFqQ@mail.gmail.com>
In-Reply-To: <201207281557.q6SFvuHE043467@svn.freebsd.org>
References:  <201207281557.q6SFvuHE043467@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 28, 2012 at 11:57 PM, Carlo Strub <cs@freebsd.org> wrote:
> Author: cs
> Date: Sat Jul 28 15:57:55 2012
> New Revision: 301663
> URL: http://svn.freebsd.org/changeset/ports/301663
>
> Log:
>   Fix typos in COMMENT
>
>   Approved by:  portmgr@ (implicit)

Hi Carlo,

Thanks for your work on COMMENT. IMHO, it would be better to have more
detailed commit log. In this commit, I noticed changes of adding
Oxford comma, using canonical/official name (e.g. ascii -> ASCII) and
removing indefinite article.

OTOH, are "adding Oxford comma" and "removing indefinite article"
mandatory now? If so, it would be great if someone add them to the
Porter's Handbook. :)

Regards,
sunpoet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QDmJQ6W6euUWw6bHvTFyXTgrcjyLxBCcaO5f1%2BNYHFqQ>