Date: Tue, 27 Feb 2007 10:13:03 GMT From: Ivan Voras <ivoras@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/109596: patch for benchmarks/unixbench: execl benchmark fails on 64-bit machines Message-ID: <200702271013.l1RAD3am068704@melc.cc.fer.hr> Resent-Message-ID: <200702271130.l1RBUA0Z003790@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 109596
>Category: ports
>Synopsis: patch for benchmarks/unixbench: execl benchmark fails on 64-bit machines
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 27 11:30:10 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Ivan Voras
>Release: FreeBSD 6.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD xxx 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 08:43:30 UTC 2007 root@portnoy.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP amd64
>Description:
execl benchmark is not 64-bit ready, and crashes when 0 is passed
to execl(2) instead of NULL.
>How-To-Repeat:
Run execl benchmark on amd64, observe the error message.
>Fix:
# This is a shell archive. Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file". Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
# unixbench_execl.patch
#
echo x - unixbench_execl.patch
sed 's/^X//' >unixbench_execl.patch << 'END-of-unixbench_execl.patch'
X--- unixbench-4.1.0/src/execl.c Wed Jul 28 21:46:58 1999
X+++ unixbench-4.1.0-new/src/execl.c Tue Feb 27 10:06:48 2007
X@@ -88,7 +88,7 @@
X fprintf(stderr, "%lu loops\n", iter);
X exit(0);
X }
X- execl(fullpath, fullpath, "0", dur_str, count_str, start_str, 0);
X+ execl(fullpath, fullpath, "0", dur_str, count_str, start_str, NULL);
X printf("Exec failed at iteration %lu\n", iter);
X perror("Reason");
X exit(1);
END-of-unixbench_execl.patch
exit
Since unixbench is unmaintained, I propose this patch be added
as a local FreeBSD ports patch.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702271013.l1RAD3am068704>