From owner-cvs-sys Sun Mar 1 09:09:14 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA04538 for cvs-sys-outgoing; Sun, 1 Mar 1998 09:09:14 -0800 (PST) (envelope-from owner-cvs-sys) Received: from hydrogen.nike.efn.org (d182-89.uoregon.edu [128.223.182.89]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA04386; Sun, 1 Mar 1998 09:08:52 -0800 (PST) (envelope-from gurney_j@efn.org) Received: (from jmg@localhost) by hydrogen.nike.efn.org (8.8.7/8.8.7) id JAA28640; Sun, 1 Mar 1998 09:08:47 -0800 (PST) Message-ID: <19980301090847.47529@hydrogen.nike.efn.org> Date: Sun, 1 Mar 1998 09:08:47 -0800 From: John-Mark Gurney To: "Jordan K. Hubbard" Cc: sos@FreeBSD.ORG, Satoshi Asami , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci pcisupport.c References: <199803011556.QAA09093@sos.freebsd.dk> <25256.888771661@time.cdrom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.69 In-Reply-To: <25256.888771661@time.cdrom.com>; from Jordan K. Hubbard on Sun, Mar 01, 1998 at 09:01:01AM -0800 Reply-To: John-Mark Gurney Organization: Cu Networking X-Operating-System: FreeBSD 2.2.1-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Jordan K. Hubbard scribbled this message on Mar 1: > > In reply to Satoshi Asami who wrote: > > > asami 1998/03/01 02:10:32 PST > > > > > > Modified files: > > > sys/pci pcisupport.c > > > Log: > > > Add Intel 430TX chipset, namely 82439TX system controller and four > > > incarnations of 82371AB (P/I bridge, IDE, USB and power management). > > > > > > Tested by: jkh > > > > This is the weakest test I've seen for a looong time :) > > Those chips are now defined TWICE... > > Really? They certainly didn't get ID'd properly before I applied > Satoshi's patch! well... maybe your talking about RELENG_2_2... but the code is there in -current and missing from RELENG_2_2... (if you take a look at the source from before this commit)... > > Who has that pointy hat, well make it two :) > > Make it three - whomever thought they added this support before > screwed it up because it certainly didn't work. :-) probably miscommunication.... a patch for one branch shouldn't be blindly merged into another brach.... -- John-Mark Gurney Modem/FAX: +1 541 683 6954 Cu Networking P.O. Box 5693, 97405 Live in Peace, destroy Micro$oft, support free software, run FreeBSD Don't trust anyone you don't have the source for