From owner-cvs-src@FreeBSD.ORG Sat Jun 11 07:25:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C429F16A41C; Sat, 11 Jun 2005 07:25:43 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from fafoe.narf.at (chello213047085026.6.14.vie.surfer.at [213.47.85.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65E0643D1D; Sat, 11 Jun 2005 07:25:43 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42]) by fafoe.narf.at (Postfix) with ESMTP id 70E6240D6; Sat, 11 Jun 2005 09:25:40 +0200 (CEST) Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 02F11C4; Sat, 11 Jun 2005 09:25:38 +0200 (CEST) Date: Sat, 11 Jun 2005 09:25:38 +0200 From: Stefan Farfeleder To: Marcel Moolenaar Message-ID: <20050611072537.GB39090@wombat.fafoe.narf.at> References: <200506110321.j5B3LKi2025443@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200506110321.j5B3LKi2025443@repoman.freebsd.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-raid.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2005 07:25:43 -0000 On Sat, Jun 11, 2005 at 03:21:20AM +0000, Marcel Moolenaar wrote: > Avoid GCC optimizations from injecting a call to memset(?) in order > to initialize the buffer array in ata_raid_attach() by removing the > initializer. There's no memset(?) in the kernel. Instead, assign > '\0' to the first element. The buffer array holds strings only, so > this is functionally equivalent. Maybe GCC should be taught to generate a bzero call instead? Stefan