From owner-svn-src-head@freebsd.org Wed Aug 26 18:42:54 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CEB373B828F for ; Wed, 26 Aug 2020 18:42:54 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BcF995JZbz4SgZ for ; Wed, 26 Aug 2020 18:42:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f68.google.com with SMTP id c15so2842430wrs.11 for ; Wed, 26 Aug 2020 11:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ncPjS7Jp5+JkNRTaEKC5JWpThjx5Kr4F44UN5FhtyKI=; b=GvJoCyi+oz250TrpEd8wiotgPO8HK3t8/4t+JlY8lmqwbv5nKoOZHN/Opfra7jbRKf Tgdl/6XwtDqVyRuwk4caPZKyPWs+/gGRCr0v2KBTSGm2yEV9S+vrpzYNMFcxgqU57HiU CfZNN4jLgewxK6iyv6cUdVIQ7C08DtwgtV5U0NnixZn7xsuxAb3qMJEUB7m13q8BiHAy N32IkE+8wY4+6EZTjO/0xuV22WkSY/ATgyhm5HNO1FCPRQUkYUmzLZH7hfejVjgwOLSN G23tJwAraUQEYchTXOtk6nvZ/KkoTBmLvzX1tLJFFL49IEl/t4WJSVmy/+9Vr/LIHzG8 w2Fw== X-Gm-Message-State: AOAM530siflqEqrcz/6/BDG/0WmomDe8f2WxQTE2dnZGCUgsHs4iaR+9 DG4BR3duhvQ/gNy6d/olv6HDBg== X-Google-Smtp-Source: ABdhPJwSLvakhc8kfYTY9x8rn4apHJ1X4GNvv0BRs7nDvWLiq362PQyAs5gm3P860u40auPZi95ABQ== X-Received: by 2002:adf:8504:: with SMTP id 4mr12088080wrh.289.1598467372227; Wed, 26 Aug 2020 11:42:52 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id b8sm8343372wrx.76.2020.08.26.11.42.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Aug 2020 11:42:51 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm From: Jessica Clarke In-Reply-To: <0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2@FreeBSD.org> Date: Wed, 26 Aug 2020 19:42:50 +0100 Cc: Ian Lepore , Mateusz Guzik , Jung-uk Kim , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <187C5112-6E19-4155-9226-FD23BA03ABA9@freebsd.org> References: <202008261655.07QGtSZx096979@repo.freebsd.org> <7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel@freebsd.org> <0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4BcF995JZbz4SgZ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.68 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-1.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.29)[-0.289]; RCPT_COUNT_SEVEN(0.00)[7]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.90)[-0.904]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.79)[-0.793]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.68:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.68:from]; FREEMAIL_CC(0.00)[FreeBSD.org,gmail.com,freebsd.org]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 18:42:54 -0000 On 26 Aug 2020, at 19:33, Dimitry Andric wrote: > > On 26 Aug 2020, at 19:13, Ian Lepore wrote: >> >> On Wed, 2020-08-26 at 19:04 +0200, Mateusz Guzik wrote: >>> On 8/26/20, Jung-uk Kim wrote: >>>> Author: jkim >>>> Date: Wed Aug 26 16:55:28 2020 >>>> New Revision: 364822 >>>> URL: https://svnweb.freebsd.org/changeset/base/364822 >>>> >>>> Log: >>>> Fix Clang version detection. >>>> >>>> We prepend "FreeBSD" to Clang version string. This broke >>>> compiler test >>>> for >>>> AVX instruction support. >>>> >>> >>> What about other software checking in similar fashion? imo the right >>> fix is to stop mucking with the way clang reports itself >>> >> >> Maybe it would be better to not modify the start of the string. >> Instead of >> >> FreeBSD clang version 9.0.1 (git@github.com:llvm/llvm-project.git >> c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) >> >> maybe >> >> clang version 9.0.1 for FreeBSD (git@github.com:llvm/llvm-project.git >> c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) > > We have been doing this since, well, forever. And this way actually > originates from upstream, we only define the CLANG_VENDOR macro. I see > no reason to change this after all those years. > > A better question is, why these perl scripts "suddenly" started failing? > Or have they also failed since forever, and it was only noticed now? Ah, digging deeper it gets more interesting. All those scripts check for "based on LLVM X.Y", a suffix printed for vendor builds. However, that was dropped in https://reviews.llvm.org/D69925 as it's redundant, thereby breaking this detection. So it's fallout from LLVM 10. Also the scripts aren't failing in a sense, they just don't know what compiler is in use so they fall back on not enabling AVX. Jess