From owner-dev-commits-src-main@freebsd.org Mon Apr 26 15:18:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB5365E44A4; Mon, 26 Apr 2021 15:18:34 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTT7G29FJz3l0v; Mon, 26 Apr 2021 15:18:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from amy (j1a01-1-78-205-69-41.fbx.proxad.net [78.205.69.41]) by mx.blih.net (OpenSMTPD) with ESMTPSA id a401260f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Apr 2021 15:18:31 +0000 (UTC) Date: Mon, 26 Apr 2021 17:18:31 +0200 From: Emmanuel Vadot To: Neel Chauhan Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: c8de6e20150a - main - linuxkpi: Elimiate brackets on return in spinlock.h Message-Id: <20210426171831.cb9961436fc128c91fe62b04@bidouilliste.com> In-Reply-To: <202104261516.13QFGkjV072950@gitrepo.freebsd.org> References: <202104261516.13QFGkjV072950@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FTT7G29FJz3l0v X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 15:18:34 -0000 On Mon, 26 Apr 2021 15:16:46 GMT Neel Chauhan wrote: > The branch main has been updated by nc (ports committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=c8de6e20150a3c10575a27532a25b00342a7f452 > > commit c8de6e20150a3c10575a27532a25b00342a7f452 > Author: Neel Chauhan > AuthorDate: 2021-04-26 15:16:48 +0000 > Commit: Neel Chauhan > CommitDate: 2021-04-26 15:16:48 +0000 > > linuxkpi: Elimiate brackets on return in spinlock.h > --- > sys/compat/linuxkpi/common/include/linux/spinlock.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sys/compat/linuxkpi/common/include/linux/spinlock.h b/sys/compat/linuxkpi/common/include/linux/spinlock.h > index 7ef474b671dc..1ad8f8ff1aad 100644 > --- a/sys/compat/linuxkpi/common/include/linux/spinlock.h > +++ b/sys/compat/linuxkpi/common/include/linux/spinlock.h > @@ -167,10 +167,10 @@ atomic_dec_and_lock_irqsave(atomic_t *cnt, spinlock_t *lock, > { > spin_lock_irqsave(lock, flags); > if (atomic_dec_and_test(cnt)) { > - return (1); > + return 1; > } > spin_unlock_irqrestore(lock, flags); > - return (0); > + return 0; > } > > #endif /* _LINUX_SPINLOCK_H_ */ That's not what Hans said, you didn't needed the brackets ('{' and '}') around the return (1); You need the parentesis around returns value. -- Emmanuel Vadot