From owner-freebsd-scsi Sun Oct 5 14:05:53 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id OAA09300 for freebsd-scsi-outgoing; Sun, 5 Oct 1997 14:05:53 -0700 (PDT) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id OAA09280; Sun, 5 Oct 1997 14:05:39 -0700 (PDT) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id NAA20636; Sun, 5 Oct 1997 13:50:51 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd020634; Sun Oct 5 20:50:42 1997 Message-ID: <3437FD62.7D55368C@whistle.com> Date: Sun, 05 Oct 1997 13:49:39 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: Poul-Henning Kamp CC: Joerg Wunsch , freebsd-scsi@FreeBSD.ORG, David Greenman Subject: Re: New SCSI Framework Patches Available References: <8140.876053997@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-scsi@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: my new disk layer stuff basically works in byte offsets. it starts with b_blkno, but all comparisins etc. end up being u_int64_t based.. (offset_t?) I'd rather see byte offsets ASAP, so that it matches the resid and other count values. of course it makes it easier to accidentally try do non-alligned transfers, but if you are making that big a, then othingis likely to help you except having your code rejected too much. > > >> > I would prefer a transition from b_blkno to b_offset, thereby > >> > eliminating all the ``shift right here, shift back left there'' mess > >> > completely. > > I agree. me too though I'd like to leave the b_pblkno, or maybe make it a b_poffset. > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop."