From owner-freebsd-stable@FreeBSD.ORG Sun Feb 24 19:59:03 2013 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8D180B45 for ; Sun, 24 Feb 2013 19:59:03 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id 5E64216D for ; Sun, 24 Feb 2013 19:59:03 +0000 (UTC) Received: from damnhippie.dyndns.org (daffy.symmetricom.us [206.168.13.218]) by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id r1OJwt2N007300; Sun, 24 Feb 2013 12:58:56 -0700 (MST) (envelope-from ian@FreeBSD.org) Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r1OJwqM6002212; Sun, 24 Feb 2013 12:58:52 -0700 (MST) (envelope-from ian@FreeBSD.org) Subject: Re: svn - but smaller? From: Ian Lepore To: Jeremy Chadwick In-Reply-To: <20130224063110.GA53348@icarus.home.lan> References: <1359320641-6493504.60501067.fr0RL3aYw027137@rs149.luxsci.com> <1359380582-6256705.77592125.fr0SDgrYH000991@rs149.luxsci.com> <20130224031509.GA47838@icarus.home.lan> <20130224041638.GA51493@icarus.home.lan> <20130224063110.GA53348@icarus.home.lan> Content-Type: text/plain; charset="us-ascii" Date: Sun, 24 Feb 2013 10:19:57 -0700 Message-ID: <1361726397.16937.4.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Michael Ross , freebsd-stable@FreeBSD.org, John Mehr X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2013 19:59:03 -0000 On Sat, 2013-02-23 at 22:31 -0800, Jeremy Chadwick wrote: > > Also, John, please consider using malloc(3) instead of heap-allocated > buffers like file_buffer[6][] (196608 bytes) and command[] (32769 > bytes). I'm referring to this: Why? I absolutely do not understand why people are always objecting to large stack-allocated arrays in userland code (sometimes with the definition of "large" being as small as 2k for some folks). -- Ian