From owner-svn-ports-all@freebsd.org  Tue Jan 23 14:09:39 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A71FAED5BAC;
 Tue, 23 Jan 2018 14:09:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 885B87D050;
 Tue, 23 Jan 2018 14:09:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id ACD2871CF; Tue, 23 Jan 2018 14:09:38 +0000 (UTC)
Date: Tue, 23 Jan 2018 14:09:38 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Dupre <ale@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files
Message-ID: <20180123140938.GA73049@FreeBSD.org>
References: <201801231358.w0NDwMa8074241@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201801231358.w0NDwMa8074241@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2018 14:09:39 -0000

On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote:
> New Revision: 459751
> URL: https://svnweb.freebsd.org/changeset/ports/459751
> 
> Log:
>   The Solidity Contract-Oriented Programming Language
>   
>   WWW: https://github.com/ethereum/solidity
> 
> Added: head/lang/solidity/Makefile
> ...
> @@ -0,0 +1,34 @@
> +# Created by: Alex Dupre <ale@FreeBSD.org>
> +# $FreeBSD$
> +
> +PORTNAME=	solidity
> +PORTVERSION=	0.4.19
> +CATEGORIES=	lang
> +MASTER_SITES=	https://github.com/ethereum/solidity/releases/download/v${PORTVERSION}/
> +DISTNAME=	${PORTNAME}_${PORTVERSION}
> +
> +MAINTAINER=	ale@FreeBSD.org
> +COMMENT=	Solidity Contract-Oriented Programming Language

COMMENT=	Contract-oriented programming language

> +OPTIONS_DEFINE=	SMT
> +SMT_DESC=	SMT Checker
> +SMT_LIB_DEPENDS=libz3.so:math/z3
> +
> +USES=		cmake

Misplaced USES.

> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"

And CMAKE_ARGS (also bogus +=).

> +pre-patch:
> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt

Excessive indentation of target recipe (commands).

> Added: head/lang/solidity/pkg-descr
> ...
> @@ -0,0 +1,3 @@
> +The Solidity Contract-Oriented Programming Language
> +
> +WWW: https://github.com/ethereum/solidity

Bad port description (verbatim copy of COMMENT), tells nothing about the
port (violation of PHB Section 3.2.1).

./danfe