From owner-svn-src-head@FreeBSD.ORG  Fri Jun  7 10:33:55 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 1121DCE5;
 Fri,  7 Jun 2013 10:33:55 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 by mx1.freebsd.org (Postfix) with ESMTP id 9010516E5;
 Fri,  7 Jun 2013 10:33:54 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r57AXrKn023342;
 Fri, 7 Jun 2013 14:33:53 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r57AXrps023341;
 Fri, 7 Jun 2013 14:33:53 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 7 Jun 2013 14:33:53 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mikolaj Golub <trociny@FreeBSD.org>, zec@FreeBSD.org,
 Nikos Vassiliadis <nvass@gmx.com>
Subject: Re: svn commit: r251490 - head/sys/net
Message-ID: <20130607103353.GB1187@FreeBSD.org>
References: <201306071027.r57ARpaF056606@svn.freebsd.org>
 <20130607103307.GA1187@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20130607103307.GA1187@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jun 2013 10:33:55 -0000

On Fri, Jun 07, 2013 at 02:33:08PM +0400, Gleb Smirnoff wrote:
T> On Fri, Jun 07, 2013 at 10:27:51AM +0000, Mikolaj Golub wrote:
T> M> Author: trociny
T> M> Date: Fri Jun  7 10:27:50 2013
T> M> New Revision: 251490
T> M> URL: http://svnweb.freebsd.org/changeset/base/251490
T> M> 
T> M> Log:
T> M>   Properly set curvnet context in lagg_port_setlladdr() task handler.
T> M>   
T> M>   Reported by:	Nikos Vassiliadis <nvass gmx.com>
T> M>   Submitted by:	zec
T> M>   Tested by:	Nikos Vassiliadis <nvass gmx.com>
T> M>   MFC after:	1 week
T> M> 
T> M> Modified:
T> M>   head/sys/net/if_lagg.c
T> M> 
T> M> Modified: head/sys/net/if_lagg.c
T> M> ==============================================================================
T> M> --- head/sys/net/if_lagg.c	Fri Jun  7 09:06:50 2013	(r251489)
T> M> +++ head/sys/net/if_lagg.c	Fri Jun  7 10:27:50 2013	(r251490)
T> M> @@ -505,7 +505,9 @@ lagg_port_setlladdr(void *arg, int pendi
T> M>  		ifp = llq->llq_ifp;
T> M>  
T> M>  		/* Set the link layer address */
T> M> +		CURVNET_SET(ifp->if_vnet);
T> M>  		error = if_setlladdr(ifp, llq->llq_lladdr, ETHER_ADDR_LEN);
T> M> +		CURVNET_RESTORE();
T> M>  		if (error)
T> M>  			printf("%s: setlladdr failed on %s\n", __func__,
T> M>  			    ifp->if_xname);
T> 
T> IMHO, the entire task function should be embraced into VNET context.

Sorry, I'm wrong. :(

-- 
Totus tuus, Glebius.