From owner-freebsd-audit Thu Aug 9 2:16:33 2001 Delivered-To: freebsd-audit@freebsd.org Received: from arb.arb.za.net (www.tarmactroopers.co.za [196.7.148.4]) by hub.freebsd.org (Postfix) with ESMTP id 2710737B401 for ; Thu, 9 Aug 2001 02:16:28 -0700 (PDT) (envelope-from mark@grondar.za) Received: (from uucp@localhost) by arb.arb.za.net (8.11.3/8.11.3) with UUCP id f799GGX27082; Thu, 9 Aug 2001 11:16:16 +0200 (SAST) (envelope-from mark@grondar.za) Received: from grondar.za (localhost [127.0.0.1]) by grimreaper.grondar.za (8.11.5/8.11.4) with ESMTP id f78LaNf12227; Wed, 8 Aug 2001 22:36:23 +0100 (BST) (envelope-from mark@grondar.za) Message-Id: <200108082136.f78LaNf12227@grimreaper.grondar.za> To: Bruce Evans Cc: audit@FreeBSD.ORG Subject: Re: [patch] su(1) WARNS=2 cleanup References: <20010808204101.O6896-100000@besplex.bde.org> In-Reply-To: <20010808204101.O6896-100000@besplex.bde.org> ; from Bruce Evans "Wed, 08 Aug 2001 21:19:17 +1000." Date: Wed, 08 Aug 2001 22:36:23 +0100 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Removing all the casts and "fixing" the types of nargv and np gives the > following patch. Now there is a fundamental fatal type mismatch between > np and execv(2)'s second parameter. np needs to have type > > char const * * > > so that it can be initialized without warnings, but it needs to have type > > char * const * > > so that it can be passed to execv(). These requirements are incompatible. > np must be cast to hide the apparent bug that it is incompatible with > execve()'s second arg, but -Wcast-qual shows that the cast is a bug. So this means that unless something "heavyweight" got done, this is unfixable? OK to commit the rest, minus the execv() arg 2 (non-)fix? (And obviously not the WARNS=2) M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message