Date: Wed, 08 Aug 2001 22:36:23 +0100 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: audit@FreeBSD.ORG Subject: Re: [patch] su(1) WARNS=2 cleanup Message-ID: <200108082136.f78LaNf12227@grimreaper.grondar.za> In-Reply-To: <20010808204101.O6896-100000@besplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Wed, 08 Aug 2001 21:19:17 %2B1000." References: <20010808204101.O6896-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Removing all the casts and "fixing" the types of nargv and np gives the > following patch. Now there is a fundamental fatal type mismatch between > np and execv(2)'s second parameter. np needs to have type > > char const * <non-const> * > > so that it can be initialized without warnings, but it needs to have type > > char <non-const> * const * > > so that it can be passed to execv(). These requirements are incompatible. > np must be cast to hide the apparent bug that it is incompatible with > execve()'s second arg, but -Wcast-qual shows that the cast is a bug. So this means that unless something "heavyweight" got done, this is unfixable? OK to commit the rest, minus the execv() arg 2 (non-)fix? (And obviously not the WARNS=2) M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108082136.f78LaNf12227>