From owner-svn-src-all@FreeBSD.ORG Fri May 24 07:23:59 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B05BE9B7; Fri, 24 May 2013 07:23:59 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) by mx1.freebsd.org (Postfix) with ESMTP id 6984E20C; Fri, 24 May 2013 07:23:59 +0000 (UTC) Received: from jre-mbp.elischer.org (ppp121-45-237-17.lns20.per1.internode.on.net [121.45.237.17]) (authenticated bits=0) by vps1.elischer.org (8.14.5/8.14.5) with ESMTP id r4O7Noal078238 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 24 May 2013 00:23:53 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <519F1581.6070900@freebsd.org> Date: Fri, 24 May 2013 15:23:45 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Michael Tuexen Subject: Re: svn commit: r250809 - head/sys/netinet References: <201305191606.r4JG6hNR032154@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2013 07:23:59 -0000 On 5/24/13 2:52 PM, Michael Tuexen wrote: > On May 24, 2013, at 8:50 AM, Michael Tuexen wrote: > >> On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote: >> >>> On Sun, 19 May 2013, Michael Tuexen wrote: >>> >>>> Author: tuexen >>>> Date: Sun May 19 16:06:43 2013 >>>> New Revision: 250809 >>>> URL: http://svnweb.freebsd.org/changeset/base/250809 >>>> >>>> Log: >>>> Initialize the fibnum for outgoing packets to 0. This avoids >>>> crashing due to the usage of uninitialized fibnum. >>>> This bugs became visiable after >>>> http://svnweb.freebsd.org/changeset/base/250700 >>> >>> That just masks the real bug, please back it out. >> And the real bug is that SCTP doesn't support multiple fibs, right? >> That would mean the system crashes on reception of an out of the blue >> SCTP packet... > OK. I just saw > http://svnweb.freebsd.org/changeset/base/250952 > > I'll back out > http://svnweb.freebsd.org/changeset/base/250809 > later today. yeah. sorry about that... > > Best regards > Michael >> Best regards >> Michael >>> >>>> MFC after: 2 weeks >>>> >>>> Modified: >>>> head/sys/netinet/sctp_os_bsd.h >>>> >>>> Modified: head/sys/netinet/sctp_os_bsd.h >>>> ============================================================================== >>>> --- head/sys/netinet/sctp_os_bsd.h Sun May 19 15:26:15 2013 (r250808) >>>> +++ head/sys/netinet/sctp_os_bsd.h Sun May 19 16:06:43 2013 (r250809) >>>> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t; >>>> { \ >>>> int o_flgs = IP_RAWOUTPUT; \ >>>> struct sctp_tcb *local_stcb = stcb; \ >>>> + M_SETFIB(o_pak, 0); \ >>>> if (local_stcb && \ >>>> local_stcb->sctp_ep && \ >>>> local_stcb->sctp_ep->sctp_socket) \ >>>> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t; >>>> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \ >>>> { \ >>>> struct sctp_tcb *local_stcb = stcb; \ >>>> + M_SETFIB(o_pak, 0); \ >>>> if (local_stcb && local_stcb->sctp_ep) \ >>>> result = ip6_output(o_pak, \ >>>> ((struct in6pcb *)(local_stcb->sctp_ep))->in6p_outputopts, \ >>>> >>> -- >>> Bjoern A. Zeeb ????????? ??? ??????? ??????: >>> '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? >>> ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.??? >>> >> > > >