From owner-freebsd-ports Thu May 31 1:47:30 2001 Delivered-To: freebsd-ports@freebsd.org Received: from heinz.jollem.com (c104187.upc-c.chello.nl [212.187.104.187]) by hub.freebsd.org (Postfix) with ESMTP id 6833B37B422; Thu, 31 May 2001 01:47:26 -0700 (PDT) (envelope-from ernst@heinz.jollem.com) Received: (from ernst@localhost) by heinz.jollem.com (8.11.3/8.11.3) id f4V8jho00787; Thu, 31 May 2001 10:45:43 +0200 (CEST) (envelope-from ernst) Date: Thu, 31 May 2001 10:45:43 +0200 From: Ernst de Haan To: dougb@FreeBSD.org Cc: freebsd-ports@FreeBSD.org Subject: Re: ports/27784: Maintainer volunteer && update: java/jdk-doc Message-ID: <20010531104543.A611@c187104187.telekabel.chello.nl> References: <200105310610.f4V6Av228606@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200105310610.f4V6Av228606@freefall.freebsd.org>; from dougb@FreeBSD.org on Wed, May 30, 2001 at 11:10:57PM -0700 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Doug, > Your port was committed with some improvements. Most notably, please > learn how to use portlint, and always sort your plist. That makes it > much much easier to diff down the road, and keeps the diffs small. Sorry, but your 'improvements' broke the port. This is not my first port, and I *do* know how to use portlint. I also know about a few quirks, one of them being that I need to define DISTFILES and not just DISTNAME if I want to check if the file to be downloaded exists and otherwise print a message. Next time when taking over a port I will regenerate the pkg-plist file, as you suggested. Ernst -- Ernst de Haan Java Architect Jollem Information Technology "Come to me all who are weary and burdened and I will give you rest" -- Jesus Christ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message