From owner-freebsd-stable@FreeBSD.ORG Tue Jun 8 09:08:13 2004 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03B4816A4CE for ; Tue, 8 Jun 2004 09:08:13 +0000 (GMT) Received: from dastardly.newsbastards.org.72.27.172.IN-addr.ARPA.NOSPAM.dyndns.dk (80-219-172-121.dclient.hispeed.ch [80.219.172.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56E4E43D31 for ; Tue, 8 Jun 2004 09:08:11 +0000 (GMT) (envelope-from bounce@NOSPAM.dyndns.dk) Received: from Mail.NOSPAM.DynDNS.dK (ipv6.NOSPAM.dyndns.dk [2002:50db:ac79:0:250:daff:fe5a:2107]) (8.11.6/8.11.6-SPAMMERS-DeLiGHt) with ESMTP id i5897x601579 verified NO) for ; Tue, 8 Jun 2004 11:08:04 +0200 (CEST) (envelope-from bounce@NOSPAM.dyndns.dk) Received: (from beer@localhost) by Mail.NOSPAM.DynDNS.dK (8.11.6/FNORD) id i5897xh01578; Tue, 8 Jun 2004 11:07:59 +0200 (CEST) (envelope-from bounce@NOSPAM.dyndns.dk) Date: Tue, 8 Jun 2004 11:07:59 +0200 (CEST) Message-Id: <200406080907.i5897xh01578@Mail.NOSPAM.DynDNS.dK> X-Authentication-Warning: localhost.newsbastards.org.72.27.172.IN-addr.A: beer set sender to bounce@NOSPAM.dyndns.dk using -f X-Authentication-Warning: localhost.newsbastards.org.72.27.172.IN-addr.A: Processed from queue /tmp X-Authentication-Warning: localhost.newsbastards.org.72.27.172.IN-addr.A: Processed by beer with -C /etc/mail/sendmail.cf-LOCAL From: Barry Bouwsma To: BSD Ranch Stable and Barnyard Subject: patch again: cvs and read-only repositories X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2004 09:08:13 -0000 [drop the above ipv6-only address that only sometimes works from the recipients and I'll catch up later from the archives, thanks] Hi! I've got the following patch in my FreeBSD4 source. Perhaps it is a candidate to be merged into RELENG_4? Pretty please? It somehow fixes the case which is somehow b0rken when one tries to update from a read-only repository (whether de-facto or as specified on the command line, I do no remember, sorry) --- tag.c-ORIG Tue Jan 21 23:26:46 2003 +++ tag.c Tue May 11 16:49:53 2004 @@ -1300,7 +1300,7 @@ /* The tags is valid but not mentioned in val-tags. Add it. */ datum value; - if (noexec || nowrite) + if (noexec || nowrite || readonlyfs) { if (db != NULL) dbm_close (db); If I could remember how to reproduce the bug, I'd say so, but as I recall, it has to do with a combination of a read- only-mounted repository and/or specifying the -R flag to the client. Without this patch, the server tries to write to the read-only repository and fails. This patch is probably based on something seen in one or more of the other BSDen. thanks barry bouwsma