From owner-freebsd-bugs Mon Feb 11 5:50:10 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 2FA8137B419 for ; Mon, 11 Feb 2002 05:50:01 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g1BDo1U45030; Mon, 11 Feb 2002 05:50:01 -0800 (PST) (envelope-from gnats) Received: from mta5.snfc21.pbi.net (mta5.snfc21.pbi.net [206.13.28.241]) by hub.freebsd.org (Postfix) with ESMTP id ECF1537B417 for ; Mon, 11 Feb 2002 05:44:17 -0800 (PST) Received: from blackbox.pacbell.net ([64.166.84.140]) by mta5.snfc21.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with ESMTP id <0GRD00GEBFHS0Z@mta5.snfc21.pbi.net> for FreeBSD-gnats-submit@freebsd.org; Mon, 11 Feb 2002 05:44:16 -0800 (PST) Received: (from mikem@localhost) by blackbox.pacbell.net (8.11.6/8.11.6) id g1BDiCr32659; Mon, 11 Feb 2002 05:44:12 -0800 (PST envelope-from mikem) Message-Id: <200202111344.g1BDiCr32659@blackbox.pacbell.net> Date: Mon, 11 Feb 2002 05:44:12 -0800 (PST) From: Mike Makonnen Reply-To: mikem To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: bin/34831: [PATCH] send-pr -a doesn't work as advertised Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 34831 >Category: bin >Synopsis: [PATCH] send-pr -a doesn't work as advertised >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 11 05:50:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: Mike Makonnen >Release: FreeBSD 5.0-CURRENT i386 >Organization: >Environment: >Description: The -a switch to send-pr doesn't attach files to the 'Fix:' section if the PR template is obtained from the environment variable $PR_FORM. I've emailed the same patch to the GNATS developers. >How-To-Repeat: >Fix: --- send-pr.diff begins here --- Index: gnu/usr.bin/send-pr/send-pr.sh =================================================================== RCS file: /home/ncvs/src/gnu/usr.bin/send-pr/send-pr.sh,v retrieving revision 1.28 diff -u -r1.28 send-pr.sh --- gnu/usr.bin/send-pr/send-pr.sh 10 Jan 2002 07:43:38 -0000 1.28 +++ gnu/usr.bin/send-pr/send-pr.sh 11 Feb 2002 13:10:26 -0000 @@ -295,6 +295,7 @@ if [ -n "$PR_FORM" -a -z "$PRINT_INTERN" ]; then cp $PR_FORM $TEMP || ( echo "$COMMAND: could not copy $PR_FORM" ; xs=1; exit ) + [ -n "$ATTACHED_FILES" ] && echo "$ATTACHED_FILES" >> $TEMP else for file in $TEMP $REF ; do cat > $file << '__EOF__' --- send-pr.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message