Date: Fri, 14 Feb 2003 16:18:23 -0600 From: Juli Mallett <jmallett@FreeBSD.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: Kirk McKusick <mckusick@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c Message-ID: <20030214161823.A82579@FreeBSD.org> In-Reply-To: <20030214221503.GA59673@nagual.pp.ru>; from ache@nagual.pp.ru on Sat, Feb 15, 2003 at 01:15:03AM %2B0300 References: <200302142131.h1ELVwvm057944@repoman.freebsd.org> <20030214153328.A78405@FreeBSD.org> <20030214221503.GA59673@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: "Andrey A. Chernov" <ache@nagual.pp.ru> [ Data: 2003-02-14 ] [ Subjecte: Re: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c ] > On Fri, Feb 14, 2003 at 15:33:28 -0600, Juli Mallett wrote: > > * De: Kirk McKusick <mckusick@FreeBSD.org> [ Data: 2003-02-14 ] > > [ Subjecte: cvs commit: src/sbin/newfs mkfs.c src/sys/ufs/ffs ffs_alloc.c ffs_vfsops.c ] > > > mckusick 2003/02/14 13:31:58 PST > > > > > > Modified files: > > > sbin/newfs mkfs.c > > > sys/ufs/ffs ffs_alloc.c ffs_vfsops.c > > > Log: > > > Replace use of random() with arc4random() to provide less guessable > > > values for the initial inode generation numbers in newfs and for > > > newly allocated inode generation numbers in the kernel. > > > > Are the sequences for it also repeatable in the newfs case for e.g. the > > regression tests, where it is used unseeded? > > Obvious answer - no. > > BTW, this fix really fixes nothing for FreeBSD case because we already use > srandomdev() (for non-regression case). Yes, I thought so, but I figured Kirk would stumble over that himself. Fixing OpenBSD deficiency by breaking FreeBSD behaviour is odd :( Thanx, juli. -- Juli Mallett <jmallett@FreeBSD.org> AIM: BSDFlata -- IRC: juli on EFnet OpenDarwin, Mono, FreeBSD Developer ircd-hybrid Developer, EFnet addict FreeBSD on MIPS-Anything on FreeBSD Never trust an ELF, COFF or Mach-O! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030214161823.A82579>