From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 24 06:40:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 690D7106566B for ; Wed, 24 Mar 2010 06:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 57F208FC12 for ; Wed, 24 Mar 2010 06:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2O6e3QH007506 for ; Wed, 24 Mar 2010 06:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2O6e3Cg007505; Wed, 24 Mar 2010 06:40:03 GMT (envelope-from gnats) Date: Wed, 24 Mar 2010 06:40:03 GMT Message-Id: <201003240640.o2O6e3Cg007505@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: bin/112673: [patch] pkg_add(1): pkg_add -S leaks the temp dir X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 06:40:04 -0000 The following reply was made to PR bin/112673; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@FreeBSD.org, jhein@timing.com Cc: Subject: Re: bin/112673: [patch] pkg_add(1): pkg_add -S leaks the temp dir Date: Tue, 23 Mar 2010 23:33:30 -0700 Hi John, (No one has replied to this PR yet in the past 3 years, so I figure I should). Yes, I've noted the same as well with my toying around with pkg_install over the past couple of days. Something's rotten in terms of how the directories are pushed and popped, in fact because many times it's not properly pushing and popping the directories in the correct / respective order. Your patch may resolve this issue, but I'm concerned about the case where a tainted directory hasn't been properly cleaned up and thus you get some of the contents of package A along with the contents of package B in the same directory, instead of properly resolving the root cause. I'll keep this bug in mind and look at proposing a solution sometime in the next couple of weeks. And the rewrite isn't completely off -- it's just been put on hold until this stuff is fixed :). Thanks, -Garrett