From owner-cvs-all@FreeBSD.ORG  Thu Dec  4 17:46:06 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 61E0F16A4CE; Thu,  4 Dec 2003 17:46:06 -0800 (PST)
Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1824043F85; Thu,  4 Dec 2003 17:46:05 -0800 (PST)
	(envelope-from eischen@vigrid.com)
Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4])
	by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id hB51k4ml002957;
	Thu, 4 Dec 2003 20:46:04 -0500 (EST)
Date: Thu, 4 Dec 2003 20:46:04 -0500 (EST)
From: Daniel Eischen <eischen@vigrid.com>
X-Sender: eischen@pcnet5.pcnet.com
To: Peter Wemm <peter@FreeBSD.org>
In-Reply-To: <200312050136.hB51aibO068399@repoman.freebsd.org>
Message-ID: <Pine.GSO.4.10.10312042042001.1477-100000@pcnet5.pcnet.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/amd64/gen makecontext.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Dec 2003 01:46:06 -0000

On Thu, 4 Dec 2003, Peter Wemm wrote:

> peter       2003/12/04 17:36:44 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libc/amd64/gen   makecontext.c 
>   Log:
>   "Fix" makecontext() so that the C code begins execution with its
>   ABI-required stack alignment.  C code expects that the push of the
>   return address disturbed the 16 byte alignment and it will take corrective
>   measures to fix it before making another call.  Of course, if its wrong
>   to start with, then all hell breaks loose.  Essentially we "fix" this
>   by making the stack alignment odd to start with.

Hey, you didn't include this little bit of knowledge in your amd64 "notes"
that you sent me ;-)

>   This was one of the things that broke on libkse with apps that use
>   floating point/varargs/etc.

I guess we never hit this problem with the tests (ACE) that we ran
on sledge...