From owner-svn-src-head@freebsd.org Sat Sep 9 20:22:19 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0108DE07DF1; Sat, 9 Sep 2017 20:22:19 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AD6227C21F; Sat, 9 Sep 2017 20:22:18 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id qmGed5mvCI8mCqmGfdDnAO; Sat, 09 Sep 2017 14:22:17 -0600 X-Authority-Analysis: v=2.2 cv=HahkdmM8 c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=2JCJgTwv5E4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=nen-iglbejSXTePDd9kA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 5A60771B; Sat, 9 Sep 2017 13:22:16 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v89KMGmg020867; Sat, 9 Sep 2017 13:22:16 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201709092022.v89KMGmg020867@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323375 - head/sys/modules/uart In-Reply-To: Message from Warner Losh of "Sat, 09 Sep 2017 20:14:18 -0000." <201709092014.v89KEITK099701@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 09 Sep 2017 13:22:16 -0700 X-CMAE-Envelope: MS4wfFYHoWQmski4URc2O/zObSDfzMW0HKmVh980evTogTfTury1kRAsqOeTkNZ7YYYo+myUgmzzIDubjKXnk2oroffIR4NtJTVwX0teuH0RWgDjpMBpEYO7 0/PETKXwfOBvovRZ5bnhLExbLdBGLXM5XZi9dls4lpYwVp68gwPWLGBcaEcHeCWaa+mZC58ePPNT6AgW/ejv5PTbWm1SSwhQ2vau1O6e+6+Ygo5+ZMamWas8 jVZvh393KsgtRfpB7XVLswjJBPM11P17R6OOy9hwL9oZpx+K2UyN+wZwao9yKdXp X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 20:22:19 -0000 In message <201709092014.v89KEITK099701@repo.freebsd.org>, Warner Losh writes: > Author: imp > Date: Sat Sep 9 20:14:18 2017 > New Revision: 323375 > URL: https://svnweb.freebsd.org/changeset/base/323375 > > Log: > Don't build uart_dev_mvebu unless we're on arm64. > > This module is specific to a single Marvel board that we currently > only support in 64-bit mode. Remove it from the build otherwise. It > likely should be completely removed, but this unbreaks x86 building. > > Noticed by: sbruno@ > > Modified: > head/sys/modules/uart/Makefile > > Modified: head/sys/modules/uart/Makefile > ============================================================================= > = > --- head/sys/modules/uart/Makefile Sat Sep 9 20:08:26 2017 (r32337 > 4) > +++ head/sys/modules/uart/Makefile Sat Sep 9 20:14:18 2017 (r32337 > 5) > @@ -25,12 +25,16 @@ _uart_cpu=uart_cpu_${MACHINE}.c > uart_cpu_machine= ${_uart_cpu} > .endif > > +.if ${MACHINE} == "arm64" > +uart_dev_mvebu=uart_dev_mvebu.c > +.endif > + > KMOD= uart > SRCS= uart_bus_acpi.c ${uart_bus_ebus} uart_bus_isa.c uart_bus_pccard > .c \ > uart_bus_pci.c uart_bus_puc.c uart_bus_scc.c \ > uart_core.c ${uart_cpu_machine} uart_dbg.c \ > ${uart_dev_lpc} uart_dev_ns8250.c uart_dev_quicc.c uart_dev_sab82532.c > \ > - uart_dev_z8530.c uart_dev_mvebu.c \ > + uart_dev_z8530.c ${uart_dev_mvebu} \ > uart_if.c uart_if.h uart_subr.c uart_tty.c > > SRCS+= acpi_if.h bus_if.h card_if.h device_if.h isa_if.h ${ofw_bus_if} > \ > Thank you. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.