From owner-svn-src-all@FreeBSD.ORG Thu Nov 27 11:08:14 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D759F1065672 for ; Thu, 27 Nov 2008 11:08:14 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by mx1.freebsd.org (Postfix) with ESMTP id 8D3AF8FC1B for ; Thu, 27 Nov 2008 11:08:14 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from c83-255-48-78.bredband.comhem.se ([83.255.48.78]:56508 helo=falcon.midgard.homeip.net) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1L5eUK-0007gV-8A for svn-src-all@freebsd.org; Thu, 27 Nov 2008 11:52:48 +0100 Received: (qmail 20112 invoked from network); 27 Nov 2008 11:46:06 +0100 Received: from owl.midgard.homeip.net (10.1.5.7) by falcon.midgard.homeip.net with ESMTP; 27 Nov 2008 11:46:06 +0100 Received: (qmail 72001 invoked by uid 1001); 27 Nov 2008 11:46:06 +0100 Date: Thu, 27 Nov 2008 11:46:06 +0100 From: Erik Trulsson To: Ivan Voras Message-ID: <20081127104606.GA71968@owl.midgard.homeip.net> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org> <20081126213204.14db9a63@kan.dnsalias.net> <20081127.000621.1413927847.imp@bsdimp.com> <9bbcef730811270220h1a7f812k2ba340737132ff82@mail.gmail.com> <8663m94g30.fsf@ds4.des.no> <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-IP: 83.255.48.78 X-Scan-Result: No virus found in message 1L5eUK-0007gV-8A. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1L5eUK-0007gV-8A f2750ce953332f4650e9307a308a23b3 Cc: svn-src-head@freebsd.org, Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2008 11:08:14 -0000 On Thu, Nov 27, 2008 at 11:38:05AM +0100, Ivan Voras wrote: > 2008/11/27 Dag-Erling Sm=F8rgrav : > > "Ivan Voras" writes: > >> And at least the newer GEOM code also uses c99 variable declarations > >> (not only for initializers - they were c99 from the start). > > > > I'm curious about what you mean with "c99 variable declarations". If > > you are referring to loop variable declarations, I can only find two > > cases, both in g_linux_lvm.c. Other than that and mixing declarations > > with statements (which style(9) explicitly forbids), there is no > > difference between c89 to c99 as far as variable declarations are > > concerned. >=20 > Yes, but not only loops - I mean things like: >=20 > if () { > struct *something abc; > int y; > ... > } >=20 > You'll probably find my code is one the biggest users of this style > but I've only started using it when I saw it already used. That construct is allowed in C89 as well. --=20 Erik Trulsson ertr1013@student.uu.se