From owner-cvs-src-old@FreeBSD.ORG Wed Nov 12 09:04:58 2008 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F297C1065678 for ; Wed, 12 Nov 2008 09:04:58 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CB1B88FC14 for ; Wed, 12 Nov 2008 09:04:58 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mAC94wN7075205 for ; Wed, 12 Nov 2008 09:04:58 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mAC94wKc075204 for cvs-src-old@freebsd.org; Wed, 12 Nov 2008 09:04:58 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200811120904.mAC94wKc075204@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Wed, 12 Nov 2008 09:04:44 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern tty_ttydisc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2008 09:04:59 -0000 ed 2008-11-12 09:04:44 UTC FreeBSD src repository Modified files: sys/kern tty_ttydisc.c Log: SVN rev 184866 on 2008-11-12 09:04:44Z by ed Don't forget to relock the TTY after uiomove() returns an error. Peter Holm just discovered this funny bug inside the TTY code: if uiomove() in ttydisc_write() returns an error, we forget to relock the TTY before jumping out of ttydisc_write(). Fix it by placing tty_unlock() and tty_lock() around uiomove(). Submitted by: pho Revision Changes Path 1.7 +2 -4 src/sys/kern/tty_ttydisc.c