From owner-cvs-all@FreeBSD.ORG Mon Feb 14 23:22:44 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0AD116A4CE; Mon, 14 Feb 2005 23:22:44 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14A4543D39; Mon, 14 Feb 2005 23:22:44 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.12] (g4.samsco.home [192.168.254.12]) (authenticated bits=0) by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j1ENN8PF030230; Mon, 14 Feb 2005 16:23:08 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <421132BF.4060507@freebsd.org> Date: Mon, 14 Feb 2005 16:22:39 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Maxime Henrion References: <421104E5.6040705@marcuscom.com> <20050214224901.GC61763@elvis.mu.org> <20050214231259.GH40468@funkthat.com> <20050214231804.GD61763@elvis.mu.org> In-Reply-To: <20050214231804.GD61763@elvis.mu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: John-Mark Gurney cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: cvs-all@freebsd.org cc: Daniel Eischen cc: Joe Marcus Clarke Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_init.cthr_init.c thr_private.h thr_stack.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 23:22:44 -0000 Maxime Henrion wrote: > John-Mark Gurney wrote: > >>Maxime Henrion wrote this message on Mon, Feb 14, 2005 at 23:49 +0100: >> >>>I entirely understand this and when I asked you why you weren't using >>>pthread_attr_setstacksize() it was out of curiosity. Anyways, I'm >>>surprised there's still an argument about this. __FreeBSD_version bumps >>>are cheap, and if it can help reduce the maintainance burden of a port, >>>I'm all for it. >> >>My point behind not doing a version bump is that if there is knowledge >>that the program needs a large/small stack, then it should ALWAYS request >>the stack size so that it is truely portable to all platforms.. instead >>of trying to berate OS xyz into increasing their default stack size... >>or end up breaking because this program tried to create 5000 threads, but >>failed because each stack took up 1MB and required 5GB of ram on a 32bit >>system.... > > > I entirely agree with you but we can't blame this on the ports > maintainers. If they want to go ahead, patch Gstreamer so that it > requests reasonably sized stacks, and send the patch back to the > vendors, that's great, but it seems that at least in the case of > Gstreamer, it's hard to do due to how the application is designed. So > we can't just refuse to bump __FreeBSD_version because Gstreamer has > problems, especially considering how cheap a __FreeBSD_version bump is. > > >>If the patch is applicable before the default change, then it is applicable >>after, and if the patch is applicable after the default change, it was >>applicable before... > > > I also agree here. :-) > > Cheers, > Maxime Oh, just bump the version already. Far too much effort is being spent on this. The ports guys have a valid need here. Scott