From owner-freebsd-fs@FreeBSD.ORG  Fri Dec  4 16:40:04 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B60871065697
	for <freebsd-fs@hub.freebsd.org>; Fri,  4 Dec 2009 16:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A4B258FC17
	for <freebsd-fs@hub.freebsd.org>; Fri,  4 Dec 2009 16:40:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB4Ge3vn009909
	for <freebsd-fs@freefall.freebsd.org>; Fri, 4 Dec 2009 16:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB4Ge3xE009908;
	Fri, 4 Dec 2009 16:40:03 GMT (envelope-from gnats)
Date: Fri, 4 Dec 2009 16:40:03 GMT
Message-Id: <200912041640.nB4Ge3xE009908@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: John Hein <jhein@symmetricom.com>
Cc: 
Subject: Re: kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(...,
 O_WRONLY|O_CREAT|O_EXCL, ...) returns io error
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Hein <jhein@symmetricom.com>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2009 16:40:04 -0000

The following reply was made to PR kern/135412; it has been noted by GNATS.

From: John Hein <jhein@symmetricom.com>
To: Jaakko Heinonen <jh@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, danny@cs.huji.ac.il, jilles@FreeBSD.org
Subject: Re: kern/135412: [zfs] [nfs] zfs(v13)+nfs and open(...,
 O_WRONLY|O_CREAT|O_EXCL, ...) returns io error
Date: Fri, 4 Dec 2009 09:37:10 -0700

 Jaakko Heinonen wrote at 08:26 +0200 on Dec  4, 2009:
  > On 2009-12-04, John Hein wrote:
  > >  But it happens when the nfs client is a FreeBSD 4.x machine or a linux
  > >  machine (tested with Fedora 10 and 11).  And it does not seem to
  > >  happen with nfs v2, just nfs v3.
  > 
  > Which FreeBSD version your server is running? There was an additional
  > fix (r197525) but it hasn't been MFCd to stable/7.
  > 
  > Here's the patch against stable/7.
  > 
  > %%%
  > Index: sys/nfsserver/nfs_serv.c
  > ===================================================================
  > --- sys/nfsserver/nfs_serv.c	(revision 200062)
  > +++ sys/nfsserver/nfs_serv.c	(working copy)
  > @@ -1743,7 +1743,7 @@ nfsrv_create(struct nfsrv_descript *nfsd
  >  			tl = nfsm_dissect_nonblock(u_int32_t *,
  >  			    NFSX_V3CREATEVERF);
  >  			/* Unique bytes, endianness is not important. */
  > -			cverf.tv_sec  = tl[0];
  > +			cverf.tv_sec  = (int32_t)tl[0];
  >  			cverf.tv_nsec = tl[1];
  >  			exclusive_flag = 1;
  >  			break;
  > %%%
 
 
 Yes, I saw the same thing, built a new kernel with that change last
 night.  I tested this morning, and it fixes the problem (and causes no
 new ones that I have seen).
 
 +1 for MFC to 7.
 
 Incidentally, is this going to have to be reworked because of
 the 32-bit time_t rollover (admittedly, still quite a ways
 away)?