From owner-freebsd-current@FreeBSD.ORG Fri Apr 20 17:39:53 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DBA5916A40B for ; Fri, 20 Apr 2007 17:39:53 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id A850313C4C8 for ; Fri, 20 Apr 2007 17:39:53 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 78540 invoked from network); 20 Apr 2007 17:25:10 -0000 Received: from ppp-71-139-34-102.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.34.102) by root.org with ESMTPA; 20 Apr 2007 17:25:10 -0000 Message-ID: <4628F76F.80608@root.org> Date: Fri, 20 Apr 2007 10:25:03 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: Yar Tikhiy References: <460AE39B.4070706@root.org> <86ps6g5759.fsf@dwp.des.no> <4617F563.40502@root.org> <200704181648.46348.jhb@freebsd.org> <20070420074423.GA22594@comp.chem.msu.su> In-Reply-To: <20070420074423.GA22594@comp.chem.msu.su> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Dag-Erling Sm?rgrav , freebsd-current@freebsd.org Subject: Re: libfetch ftp patch for less latency X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2007 17:39:53 -0000 Yar Tikhiy wrote: > On Wed, Apr 18, 2007 at 04:48:45PM -0400, John Baldwin wrote: >> On Saturday 07 April 2007 15:47, Nate Lawson wrote: >>> Dag-Erling Sm?rgrav wrote: >>>> Nate Lawson writes: >>>>> Obviously, it's easier to do nothing than something. So here are some >>>>> options: >>>>> >>>>> 1. Add my patch -- if a server returns an error, I see no way it would >>>>> have changed the PWD. If you say "CD GARBAGE", what reasonable system >>>>> would return an error and change to some random dir? >>>>> >>>>> 2. Add an env variable (similar to FTP_PASSIVE_MODE, say >>>>> "FTP_SINGLE_CWD") which forces the current behavior. If not set, fetch >>>>> tries the multi-method first, falls back to the single-method on error. >>>> No. >>>> >>>> Thanks, >>>> >>>> DES >>> I forgot: >>> >>> 3. #ifdef (on or off by default) >>> >>> Also, can I hear from anyone else besides Mr. No? >> I'm hestitant to make fetch explicitly not follow the RFC. At the least it >> should follow the RFC by default. Having it not follow the RFC actually >> broke stuff at work until I fixed it. > > I believe that the proposed feature should be conditional on the > TVFS extension in the server (RFC 3659) as it indeed violates the > basic FTP protocol. OTOH, TVFS seems to provide guarantees that > a single CWD will work as expected. > I'll do the work if this is acceptable. -- Nate