From owner-svn-ports-all@freebsd.org Tue Sep 15 21:51:29 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D53EB9CDC97 for ; Tue, 15 Sep 2015 21:51:29 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 986941F8F for ; Tue, 15 Sep 2015 21:51:29 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 84290 invoked by uid 89); 15 Sep 2015 21:51:22 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 15 Sep 2015 21:51:22 -0000 Received: (qmail 84236 invoked by uid 89); 15 Sep 2015 21:51:05 -0000 Received: by simscan 1.3.1 ppid: 84227, pid: 84231, t: 0.0040s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 15 Sep 2015 21:51:05 -0000 Received: (qmail 18896 invoked by uid 89); 15 Sep 2015 21:51:05 -0000 Received: by simscan 1.4.0 ppid: 18880, pid: 18892, t: 0.6728s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 15 Sep 2015 21:51:04 -0000 From: Jan Beich To: Jason Unovitch Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396965 - head/textproc/smi In-Reply-To: <201509151504.t8FF4siS037935@repo.freebsd.org> (Jason Unovitch's message of "Tue, 15 Sep 2015 15:04:54 +0000 (UTC)") References: <201509151504.t8FF4siS037935@repo.freebsd.org> Date: Tue, 15 Sep 2015 23:50:49 +0200 Message-ID: <7fnr-2vye-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2015 21:51:29 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jason Unovitch writes: > textproc/smi: Remove PREFIX and MANPREFIX edits inherited through MAKE_= ENV > > PR: 196224 > Reported by: jbeich [...] > post-patch: > - ${REINPLACE_CMD} -e 's|^CC =3D .*|CC =3D ${CC}|' \ > - -e 's|^PREFIX =3D .*|PREFlX =3D ${PREFIX}|' \ > - -e 's|^MANPREFIX =3D .*|MANPREFIX =3D ${MANPREFIX}|' \ > - ${WRKSRC}/config.mk > + ${REINPLACE_CMD} -e 's|^CC =3D .*|CC =3D ${CC}|' ${WRKSRC}/config.mk >=20=20 > do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/smi ${STAGEDIR}${PREFIX}/bin > The commit message is misleading. PREFIX and MANPREFIX from MAKE_ENV (unlike MAKE_ARGS) are not inherited but unused due to custom do-install in the port. do-install and post-patch existence suggest vendor Makefile isn't very useful and is riddled with issues. For an unfixed one, see bug 203137. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJV+JK5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bkyUIAIpOCa6Q8UL9CISDQrctHtY+ uKd6uCiFG5cvuQj/3blJWI6bzlIOfMOzDd35Enw/xO5+BinTeN/7oZCcz8GwlZ/+ KvBEvQH0sbb7I/Gvq64SqT6GJLAya+QT8zY4Ooo++Pj5pqBQX9iZDS0JkPYCkIg7 ECLW96T1/ibeoM5UT0hTVizKp4lQvJYD4e0L3PvaGhFNw+q0Pgu2q75CGLSLo8Lz jDBNc8Gz9miC9d1vxnt2Rs6WlbAWSPGNpofCOW4cMq/huIydm9fpOcOIGK6vqrCi K2lJmJBfYyY+4FVAKBi/iXWWg7zwcLW5LweYUUYI3tlI1WJqlpaS1m/4rOYMs5k= =ET4a -----END PGP SIGNATURE----- --=-=-=--