From owner-freebsd-ports@FreeBSD.ORG Sun Jun 11 01:59:15 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8F0216A41F for ; Sun, 11 Jun 2006 01:59:15 +0000 (UTC) (envelope-from boris@brooknet.com.au) Received: from jay.exetel.com.au (jay.exetel.com.au [220.233.0.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA75D43D49 for ; Sun, 11 Jun 2006 01:59:13 +0000 (GMT) (envelope-from boris@brooknet.com.au) Received: (qmail 1053 invoked by uid 507); 11 Jun 2006 11:59:12 +1000 Received: from 180.205.233.220.exetel.com.au (HELO ?192.168.0.157?) (220.233.205.180) by jay.exetel.com.au with SMTP; 11 Jun 2006 11:59:12 +1000 In-Reply-To: <448B74BF.20203@FreeBSD.org> References: <448B0127.1040107@isc.org> <448B655E.70003@FreeBSD.org> <448B6EDF.4040401@isc.org> <448B74BF.20203@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v750) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <64E1E60A-9AFF-4C93-A8D1-D6CC8B1BCBDC@brooknet.com.au> Content-Transfer-Encoding: 7bit From: Sam Lawrance Date: Sun, 11 Jun 2006 11:59:14 +1000 To: Doug Barton X-Mailer: Apple Mail (2.750) Cc: FreeBSD Ports , Boris Kovalenko , Peter Losher Subject: Re: FreeBSD Port: net/quagga X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jun 2006 01:59:15 -0000 On 11/06/2006, at 11:41 AM, Doug Barton wrote: > Peter Losher wrote: >> Doug Barton wrote: >> >>>> Is there any way to tell the quagga.sh script when it's in >>>> local/etc/rc.d to run at network setup instead of at the end? >>> Yes, upgrade to 6.1 or 6-stable where this issue has been addressed. >> >> Doug, >> >> As simple as I am sure that solution sounds, > > I didn't say it was simple, or even that it sounds simple. You > asked for a > solution, so I gave you a solution. :) I should perhaps have added > that this > suggestion was in lieu of the rather obvious one that you had already > described in your post, moving the startup script to /etc/rc.d by > hand. I > can certainly see how neither one of those may be the most attractive > solutions possible, but they _are_ solutions. > >> If this is "they way things are going to be" then I certainly request >> that there be put in place some glue (like USE_RCORDER) so that >> those of >> us that can't jump can still take advantage of those ports that >> require >> priority startup functionality to function. > > For the very few ports that actually need it, USE_RCORDER is still > there. I > don't know why the port author decided not to use it, hopefully he can > respond on that point. That variable is deprecated, but where it is > still > needed, it can still be used. I would suggestion something like: > > .if ${OSVERSION} < 600101 > USE_RCORDER= foo > .else > USE_RC_SUBR= foo > .endif In that case we should remove the check from portlint, until USE_RC_ORDER is no longer required by supported systems. Otherwise it's just another confusing portlint warning. The port author removed it because portlint said it was deprecated. Can USE_RC_ORDER still be used on all supported FreeBSD versions without negative effect? If there is a need to conditionalize behaviour on OSVERSION, it could be handled in bsd.port.mk (depending on how many ports need it, really).