From owner-freebsd-current@FreeBSD.ORG Mon Sep 15 02:54:46 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F11E0106567D; Mon, 15 Sep 2008 02:54:44 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 5DA338FC1F; Mon, 15 Sep 2008 02:54:43 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (adsl172-222.kln.forthnet.gr [62.1.21.222]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id m8F2sT5l006647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 15 Sep 2008 05:54:36 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.3/8.14.3) with ESMTP id m8F2sSDY002454; Mon, 15 Sep 2008 05:54:28 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.3/8.14.3/Submit) id m8F2sQTB002453; Mon, 15 Sep 2008 05:54:26 +0300 (EEST) (envelope-from keramida@freebsd.org) From: Giorgos Keramidas To: Julian Elischer References: <87prnjh80z.fsf@kobe.laptop> <48CC14AD.4090708@elischer.org> <874p4ju8t3.fsf@kobe.laptop> <87zlmbstv1.fsf@kobe.laptop> <48CCAF23.1010605@elischer.org> <87tzcij383.fsf@kobe.laptop> <48CD6266.4030008@elischer.org> Date: Mon, 15 Sep 2008 05:54:14 +0300 In-Reply-To: <48CD6266.4030008@elischer.org> (Julian Elischer's message of "Sun, 14 Sep 2008 12:13:42 -0700") Message-ID: <87fxo2qfu1.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-MailScanner-ID: m8F2sT5l006647 X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-4.521, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL -0.12, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: freebsd-current@freebsd.org, Robert Watson Subject: Re: panic in rt_check_fib() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2008 02:54:47 -0000 --=-=-= On Sun, 14 Sep 2008 12:13:42 -0700, Julian Elischer wrote: > Giorgos Keramidas wrote: >> Now an interesting question is: Is it `normal' that the USED rtentry >> objects keep going up at every interface restart and are (at least at >> first glance) not reclaimed as fast as they are acquired? > > does it happen with the old rt_check in the case where it doesn't crash? Hi Julian, Yes it happens with the old kernel too. I tried bringing the re0 interface up and down with a kernel compiled from a clean copy of base/head @ 182948. The rtentry's allocated seem to be going linearly up every time I restart the interface with the old, unpatched rt_check_fib() too. So if there is an rtentry leak, it exists in both the unpatched and the patched kernels. By going through the last rt_check_fib() you sent, I don't see an obvious place where the leak could occur in *this* function, so I will try to see if it's easier to find out where rtentry's are pulled from the related zone. Then by correlating these with the places where rtentry's are freed it may become more obvious why/when the USED objects get bumped. It may be just a missing RT_REMREF() elsewhere, but I can't tell for sure yet where/when this happens... I'll keep looking. In the meantime, the new rt_check_fib() has saved me from several semi-random panics a week, so I think I like it :-D --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjNzmIACgkQ1g+UGjGGA7ZziQCbBWdjFqgHVjDGC650jh1Vk9J8 cZwAoL6pz63aXDTFyyOaL3ML4OEWq8eA =kfLK -----END PGP SIGNATURE----- --=-=-=--