Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Feb 2018 19:34:13 +0800
From:      Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r462121 - head/lang/ruby25
Message-ID:  <CAMHz58TYexi==eSC_qidsm-odHN1dtqrf5XyDZn-EN=bQAaoPA@mail.gmail.com>
In-Reply-To: <201802180455.w1I4tjXX058950@slippy.cwsent.com>
References:  <sunpoet@freebsd.org> <CAMHz58R=n-FuWjWscvuC_1Pvze=AQeVHoSQ9xTc%2Bhj9B0Jy4uw@mail.gmail.com> <201802180455.w1I4tjXX058950@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 18, 2018 at 12:55 PM, Cy Schubert <Cy.Schubert@cschubert.com>
wrote:

> In message <CAMHz58R=n-FuWjWscvuC_1Pvze=AQeVHoSQ9xTc+hj9B0Jy4uw@mail.gma
> il.com>
> , Sunpoet Po-Chuan Hsieh writes:
> > --001a113fd9a81216cf0565674c82
> > Content-Type: text/plain; charset="UTF-8"
> >
> > Sorry for the wrong commit log. It should be "Fix typo".
>
> This comment is fine for the mailing list but anyone looking through
> the commit logs a year from now will scratch their head wondering WTF.
> Can you revert this commit, please, and recommit it with the correct
> commit log message?
>
>
Done in r462219 and r462220. Thanks!

>
> >
> > On Sat, Feb 17, 2018 at 7:59 PM, Sunpoet Po-Chuan Hsieh <
> sunpoet@freebsd.org
> > > wrote:
> >
> > > Author: sunpoet
> > > Date: Sat Feb 17 11:59:12 2018
> > > New Revision: 462121
> > > URL: https://svnweb.freebsd.org/changeset/ports/462121
> > >
> > > Log:
> > >   Remove unnecessary patches
> > >
> > >   We do not need to patch those files which will be regenerated during
> > > build.
> > >
> > >   Reference:    https://bugs.ruby-lang.org/issues/14261
> > >   PR:           225470
> > >
> > > Modified:
> > >   head/lang/ruby25/Makefile
> > >
> > > Modified: head/lang/ruby25/Makefile
> > > ============================================================
> > > ==================
> > > --- head/lang/ruby25/Makefile   Sat Feb 17 11:59:07 2018
> (r462120)
> > > +++ head/lang/ruby25/Makefile   Sat Feb 17 11:59:12 2018
> (r462121)
> > > @@ -141,7 +141,7 @@ post-patch:
> > >  post-build:
> > >  #
> > >  # Hack to allow modules to be installed into separate PREFIX and/or
> under
> > > user
> > > -# privilegies
> > > +# privileges
> > >  #
> > >         @${RB_SET_CONF_VAR} "prefix" "ENV['PREFIX'] || \3"
> > >         @${RB_SET_CONF_VAR} "INSTALL" "'/usr/bin/install -c'"
> > >
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
>
>         The need of the many outweighs the greed of the few.
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TYexi==eSC_qidsm-odHN1dtqrf5XyDZn-EN=bQAaoPA>