From owner-freebsd-bugs@FreeBSD.ORG  Sat Nov  7 21:50:05 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DDD7E1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  7 Nov 2009 21:50:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id CD7298FC1A
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  7 Nov 2009 21:50:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA7Lo5B0077918
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 7 Nov 2009 21:50:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA7Lo53g077917;
	Sat, 7 Nov 2009 21:50:05 GMT (envelope-from gnats)
Date: Sat, 7 Nov 2009 21:50:05 GMT
Message-Id: <200911072150.nA7Lo53g077917@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/119564: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Nov 2009 21:50:05 -0000

The following reply was made to PR kern/119564; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/119564: commit references a PR
Date: Sat,  7 Nov 2009 21:46:44 +0000 (UTC)

 Author: attilio
 Date: Sat Nov  7 21:46:34 2009
 New Revision: 199024
 URL: http://svn.freebsd.org/changeset/base/199024
 
 Log:
   Use a safety belt for cases where corrupted narg can be passed to the
   ktrsyscall(). print_number() does decrement the number of arguments,
   leading to infinite loops for negative values.
   
   Reported by:	Patrick Lamaiziere <patpr at davenulle dot org>,
   		Jonathan Pascal <jkpyvxmzsa at mailinator dot com>
   Submitted by:	jh
   PR:		bin/120055, kern/119564
   MFC:		1 week
 
 Modified:
   head/usr.bin/kdump/kdump.c
 
 Modified: head/usr.bin/kdump/kdump.c
 ==============================================================================
 --- head/usr.bin/kdump/kdump.c	Sat Nov  7 21:28:21 2009	(r199023)
 +++ head/usr.bin/kdump/kdump.c	Sat Nov  7 21:46:34 2009	(r199024)
 @@ -799,7 +799,7 @@ ktrsyscall(struct ktr_syscall *ktr)
  				narg--;
  			}
  		}
 -		while (narg) {
 +		while (narg > 0) {
  			print_number(ip,narg,c);
  		}
  		(void)putchar(')');
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"