From owner-freebsd-ports@freebsd.org Sun Sep 16 20:08:27 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E763B10A9217 for ; Sun, 16 Sep 2018 20:08:26 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from mailer.gwdg.de (mailer.gwdg.de [134.76.10.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 891B37E4D7 for ; Sun, 16 Sep 2018 20:08:26 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from excmbx-24.um.gwdg.de ([134.76.9.234] helo=email.gwdg.de) by mailer.gwdg.de with esmtp (Exim 4.90_1) (envelope-from ) id 1g1dL9-0001CV-0b; Sun, 16 Sep 2018 22:08:19 +0200 Received: from krabat.raven.hur (91.8.156.212) by EXCMBX-24.um.gwdg.de (134.76.9.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.1531.3; Sun, 16 Sep 2018 22:08:18 +0200 Subject: Re: pkg-plist and stage directory for new port To: Marco Beishuizen CC: FreeBSD Ports References: <_rTKdZNUI1ulLacZQn9a0ZgOA6w8IlUrUkgb96rER7AyW5LPetvQZQQWYDjRWNFRxZrT1qkzM-v76wX-7q4yOJ4cAu6G3EcLkSYqHCBM9kQ=@protonmail.ch> From: Rainer Hurling Message-ID: Date: Sun, 16 Sep 2018 22:08:12 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Originating-IP: [91.8.156.212] X-ClientProxiedBy: EXCMBX-03.um.gwdg.de (134.76.9.218) To EXCMBX-24.um.gwdg.de (134.76.9.234) X-Virus-Scanned: (clean) by clamav X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2018 20:08:27 -0000 Hi Marco, just a few comments about your port stub. Am 14.09.18 um 17:31 schrieb Marco Beishuizen: > On Fri, 14 Sep 2018, the wise Lorenzo Salvadore via freebsd-ports wrote: > >> Show us your makefile please. > > The Makefile I have so far: > > PORTNAME=        pgadmin4 > PORTVERSION=        3.3 > CATEGORIES=        databases > MASTER_SITES=        PGSQL/pgadmin/pgadmin4/v${PORTVERSION}/source/ I would insert the next line, because it is common for Postgres ports for years now, to hold the distfiles under distfiles/postgresql/ DIST_SUBDIR= postgresql I think, the following line is not necessary, the port fetches and build fine without it: > DISTNAME=        pgadmin4-${PORTVERSION} > > MAINTAINER=        mbeis@xs4all.nl > COMMENT=        PostgreSQL Administration Tool > > LICENSE=        PostgreSQL > > BUILD_DEPENDS        sphinx-build:textproc/py-sphinx > USES=            pgsql python qmake:outsource qt:5 > USE_QT=            core gui network widgets > QMAKE_SOURCE_PATH=    ${WRKSRC}/runtime > > .include > >> When I created my first port, I remember I had some difficulty to >> understand staging: imho it needs to be explained better in the >> documentation. Are you aware of the variable ${STAGEDIR}? You probably >> need to add to your makefile some lines similar to the followings: >> >> do-install: >>   ${INSTALL_PROGRAM} ${WRKSRC}/??/pgAdmin4 ${STAGEDIR}${PREFIX}/bin > > Quite possible that it's something like this. I'll dig into it. Most of the needed stuff seems to be under ${WORKSRC}/runtime and ${WORKSRC}/web. HTH a little bit. Greetings, Rainer > > Thanks, > > Marco >