Date: Wed, 15 Jan 2014 13:17:16 GMT From: Volodymyr Kostyrko <arcade@b1t.name> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/185800: net/remmina-plugins - multiple install issues Message-ID: <201401151317.s0FDHGjL092438@oldred.freebsd.org> Resent-Message-ID: <201401151320.s0FDK11r063271@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 185800
>Category: misc
>Synopsis: net/remmina-plugins - multiple install issues
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 15 13:20:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Volodymyr Kostyrko
>Release: stable/10
>Organization:
none
>Environment:
FreeBSD ar1l0u 10.0-PRERELEASE FreeBSD 10.0-PRERELEASE #27 r260622M: Tue Jan 14 11:48:00 EET 2014 arcade@ar1l0u:/usr/obj/usr/src/sys/MINIMAL amd64
>Description:
Some remmina plugins fail to build/install. Attached patch fixes two issues:
* -i18n circular dependency;
* -vnc missed dep for net/libvncserver.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 339776)
+++ Makefile (working copy)
@@ -34,6 +34,10 @@
.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MNLS}
+RUN_DEPENDS+= ${LOCALBASE}/share/locale/bg/LC_MESSAGES/remmina-plugins.mo:${PORTSDIR}/net/remmina-plugin-i18n
+.endif
+
.if ${PORT_OPTIONS:MKEYRING}
RUN_DEPENDS+= ${LOCALBASE}/lib/remmina/plugins/remmina-plugins-gnome.so:${PORTSDIR}/net/remmina-plugin-gnome
.endif
Index: bsd.plugin.mk
===================================================================
--- bsd.plugin.mk (revision 339776)
+++ bsd.plugin.mk (working copy)
@@ -38,10 +38,6 @@
PLIST_SUB+= SSH="@comment "
.endif
-.if ${PORT_OPTIONS:MNLS}
-RUN_DEPENDS+= ${LOCALBASE}/share/locale/bg/LC_MESSAGES/remmina-plugins.mo:${PORTSDIR}/net/remmina-plugin-i18n
-.endif
-
.include <bsd.port.pre.mk>
.if ${PKGNAMESUFFIX} == "-i18n" || ${PKGNAMESUFFIX} == "-gnome"
@@ -51,6 +47,10 @@
PLIST= ${PKGDIR}/pkg-plist.plugin
.endif
+.if ${PKGNAMESUFFIX} == "-vnc"
+LIB_DEPENDS+= libvncserver.so:${PORTSDIR}/net/libvncserver
+.endif
+
post-patch:
@# do not build remmina core program
${REINPLACE_CMD} -e 's|add_subdirectory(remmina)||' ${WRKSRC}/CMakeLists.txt
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401151317.s0FDHGjL092438>