From owner-cvs-all Sun Jan 6 14:46:17 2002 Delivered-To: cvs-all@freebsd.org Received: from niwun.pair.com (niwun.pair.com [209.68.2.70]) by hub.freebsd.org (Postfix) with SMTP id 1FFC237B41C for ; Sun, 6 Jan 2002 14:45:54 -0800 (PST) Received: (qmail 90828 invoked by uid 3193); 6 Jan 2002 22:45:53 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 Jan 2002 22:45:53 -0000 Date: Sun, 6 Jan 2002 17:45:53 -0500 (EST) From: Mike Silbersack X-Sender: To: Bruce Evans Cc: Mike Silbersack , , Subject: Re: cvs commit: src/sys/kern uipc_socket2.c In-Reply-To: <20020106222133.H3630-100000@gamplex.bde.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 6 Jan 2002, Bruce Evans wrote: > Er, this was already fixed (mostly better) in rev.1.19. Quad arithmetic > is used to inhibit overflow. Overflow can only occur for multi-gigabyte > buffer sizes which can only even occur in theory on machines with > u_long larger than 32 bits (since sb_max has type u_long). But sb_max's > larger than UINT_MAX cause bugs in sbreserve anyway, since the wrong > min() function is used for limiting sb->sb_max to sb_max. > > Bruce Urk, I assumed quad meant 8*4 bits. I'll revert the change. As for the (?)min functions... why are they defined in libkern.h, rather than types.h. Isn't min a compiler builtin? Thanks, Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message