Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Nov 2012 20:16:59 +0100
From:      Frederic Culot <culot@FreeBSD.org>
To:        Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Cc:        svn-ports-head@FreeBSD.org, Frederic Culot <culot@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r307927 - head/www/reviewboard
Message-ID:  <20121128191659.GC40217@culot.org>
In-Reply-To: <50B65E6D.9030403@yandex.ru>
References:  <201211281830.qASIUOST007742@svn.freebsd.org> <50B65E6D.9030403@yandex.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
> Hi Frederic,
> 
> Frederic Culot wrote on 28.11.2012 22:30:
> >Author: culot
> >Date: Wed Nov 28 18:30:23 2012
> >New Revision: 307927
> >URL: http://svnweb.freebsd.org/changeset/ports/307927
> >
> >Log:
> >   - Update to 1.6.14 [1]
> >   - use dirrmtry in plist for shared python directories to silence
> >     pkg_delete warnings
> 
> [...]
> 
> >  @dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%
> >-@dirrm %%PYTHON_SITELIBDIR%%
> >-@dirrm lib/python2.7
> >+@dirrmtry %%PYTHON_SITELIBDIR%%
> >+@dirrmtry lib/python2.7
> 
> They should be just removed altogether, because this directories
> were created by python port, not that reviewboard port. The second
> note - plist entries should not contain hardcoded paths like
> lib/python2.7, because in case user prefer to use python 2.6 or 3.2,
> this path will be lib/python2.6 and lib/python3.2. There is
> %%PYTHON_LIBDIR%% for such things, but it doesn't matter in this
> case, because they just should be removed.
> 
> -- 
> Regards,
> Ruslan
> 
> Tinderboxing kills... the drives.

Hi Ruslan,

I was not sure about this but you are right, there is no need to keep
them in plist. I just committed a patch to remove them.

Many thanks for your feedback!

Frederic



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121128191659.GC40217>