From owner-svn-ports-all@FreeBSD.ORG  Wed Nov 28 19:28:04 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 4B257A52;
 Wed, 28 Nov 2012 19:28:04 +0000 (UTC) (envelope-from culot@0xd0.org)
Received: from 0xd0.org (0xd0.org [91.121.92.146])
 by mx1.freebsd.org (Postfix) with ESMTP id C98CB8FC08;
 Wed, 28 Nov 2012 19:28:03 +0000 (UTC)
Received: from 0xd0.org (doudou.0xd0.org [172.16.0.254])
 by 0xd0.org (8.14.5/8.14.5) with ESMTP id qASJH02w027084;
 Wed, 28 Nov 2012 20:17:00 +0100 (CET) (envelope-from culot@0xd0.org)
Received: (from culot@localhost)
 by 0xd0.org (8.14.5/8.14.5/Submit) id qASJGxc4027081;
 Wed, 28 Nov 2012 20:16:59 +0100 (CET) (envelope-from culot)
Date: Wed, 28 Nov 2012 20:16:59 +0100
From: Frederic Culot <culot@FreeBSD.org>
To: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Subject: Re: svn commit: r307927 - head/www/reviewboard
Message-ID: <20121128191659.GC40217@culot.org>
References: <201211281830.qASIUOST007742@svn.freebsd.org>
 <50B65E6D.9030403@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <50B65E6D.9030403@yandex.ru>
X-PGP-Key: http://culot.org/public/pgp-key.txt
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, Frederic Culot <culot@FreeBSD.org>,
 svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2012 19:28:04 -0000

> Hi Frederic,
> 
> Frederic Culot wrote on 28.11.2012 22:30:
> >Author: culot
> >Date: Wed Nov 28 18:30:23 2012
> >New Revision: 307927
> >URL: http://svnweb.freebsd.org/changeset/ports/307927
> >
> >Log:
> >   - Update to 1.6.14 [1]
> >   - use dirrmtry in plist for shared python directories to silence
> >     pkg_delete warnings
> 
> [...]
> 
> >  @dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%
> >-@dirrm %%PYTHON_SITELIBDIR%%
> >-@dirrm lib/python2.7
> >+@dirrmtry %%PYTHON_SITELIBDIR%%
> >+@dirrmtry lib/python2.7
> 
> They should be just removed altogether, because this directories
> were created by python port, not that reviewboard port. The second
> note - plist entries should not contain hardcoded paths like
> lib/python2.7, because in case user prefer to use python 2.6 or 3.2,
> this path will be lib/python2.6 and lib/python3.2. There is
> %%PYTHON_LIBDIR%% for such things, but it doesn't matter in this
> case, because they just should be removed.
> 
> -- 
> Regards,
> Ruslan
> 
> Tinderboxing kills... the drives.

Hi Ruslan,

I was not sure about this but you are right, there is no need to keep
them in plist. I just committed a patch to remove them.

Many thanks for your feedback!

Frederic