From owner-cvs-all@FreeBSD.ORG  Wed Apr 16 11:38:53 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9CFA937B401; Wed, 16 Apr 2003 11:38:53 -0700 (PDT)
Received: from zibbi.icomtek.csir.co.za (zibbi.icomtek.csir.co.za
	[146.64.24.58])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EF89D43FB1; Wed, 16 Apr 2003 11:38:50 -0700 (PDT)
	(envelope-from jhay@zibbi.icomtek.csir.co.za)
Received: from zibbi.icomtek.csir.co.za (localhost [IPv6:::1])
	h3GIcl5v042467;	Wed, 16 Apr 2003 20:38:47 +0200 (SAST)
	(envelope-from jhay@zibbi.icomtek.csir.co.za)
Received: (from jhay@localhost)
	by zibbi.icomtek.csir.co.za (8.12.9/8.12.9/Submit) id h3GIclML042466;
	Wed, 16 Apr 2003 20:38:47 +0200 (SAST)
	(envelope-from jhay)
Date: Wed, 16 Apr 2003 20:38:46 +0200
From: John Hay <jhay@icomtek.csir.co.za>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20030416183846.GA41630@zibbi.icomtek.csir.co.za>
References: <200304161742.h3GHgc0l085079@repoman.freebsd.org>
	<XFMail.20030416140625.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <XFMail.20030416140625.jhb@FreeBSD.org>
User-Agent: Mutt/1.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/wl if_wl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2003 18:38:54 -0000

On Wed, Apr 16, 2003 at 02:06:25PM -0400, John Baldwin wrote:
> 
> On 16-Apr-2003 John Hay wrote:
> > jhay        2003/04/16 10:42:38 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/wl           if_wl.c 
> >   Log:
> >   Add locking and remove all the spl() calls.
> 
> Note that some of the spl calls covered structures other than
> just the softc.  I'd prefer that we leave spl calls in until
> all the structures they cover are locked.

Ok, should I put them all back? Or just the ones being used as
interrupt disablers? And what about the places where there
should have been splx()es but weren't?

John
-- 
John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org