From owner-freebsd-current@freebsd.org Mon Mar 21 16:23:42 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25920AD8C2D for ; Mon, 21 Mar 2016 16:23:42 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.auburn.protected-networks.net (mail.auburn.protected-networks.net [202.12.127.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.auburn.protected-networks.net", Issuer "Protected Networks Root CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E5CB32BD; Mon, 21 Mar 2016 16:23:41 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.auburn.protected-networks.net (localhost.auburn.protected-networks.net [127.0.0.1]) by mail.auburn.protected-networks.net (Postfix) with ESMTP id ED3EA7F; Mon, 21 Mar 2016 12:23:39 -0400 (EDT) Received: from mail.auburn.protected-networks.net ([127.0.0.1]) by mail.auburn.protected-networks.net (mail.auburn.protected-networks.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yIcbvcsInjsw; Mon, 21 Mar 2016 12:23:37 -0400 (EDT) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "Iain Michael Butler", Issuer "Protected Networks CA" (verified OK)) (Authenticated sender: imb@mail.auburn.protected-networks.net) by mail.auburn.protected-networks.net (Postfix) with ESMTPSA id 90767E; Mon, 21 Mar 2016 12:23:36 -0400 (EDT) Subject: Re: SVN r296987 -> r297000 breaks Sil 3124 channel attach To: Justin Hibbits References: <56F01D41.9000607@protected-networks.net> Cc: freebsd-current From: Michael Butler Openpgp: id=6F63E6399DCC8E3E94D60F0642FF6BAE0442D492 Message-ID: <56F02007.1010603@protected-networks.net> Date: Mon, 21 Mar 2016 12:23:35 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 16:23:42 -0000 On 03/21/16 12:14, Justin Hibbits wrote: > You're right. On line 323 of sys/dev/siis/siis.c, try replacing > 'long' with 'rman_res_t', as I did for ahci.c. If this works, tonight > I'll commit the fix. I envision there may be others using 'long' > instead of 'u_long' for rman (u_long was the correct form until > rman_res_t, so signed long was already a bug). > > - Justin > > On Mon, Mar 21, 2016 at 11:11 AM, Michael Butler > wrote: >> Something between SVN r296987 and r297000 causes the following errors in >> dmesg .. and the loss of the attached disks: >> >> siisch0: at channel 0 on siis0 >> device attach: siisch0 attach returned 6 >> siisch1: at channel 1 on siis0 >> device attach: siisch0 attach returned 6 >> siisch2: at channel 2 on siis0 >> device attach: siisch0 attach returned 6 >> siisch3: at channel 3 on siis0 >> device attach: siisch0 attach returned 6 >> >> I can't see anything but r297000 causing this :-( That was it - perfect! Thanks :-) pcib2: at device 30.0 on pci0 pci2: on pcib2 siis0: port 0xecf0-0xecff mem 0xfe1ffc00-0xfe1ffc7f,0xfe1f0000-0xfe1f7fff irq 22 at device 1.0 on pci2 siisch0: at channel 0 on siis0 siisch1: at channel 1 on siis0 siisch2: at channel 2 on siis0 siisch3: at channel 3 on siis0 Michael