Date: Mon, 11 Jan 1999 14:57:25 -0800 (PST) From: Julian Elischer <julian@whistle.com> To: Matthew Jacob <mjacob@feral.com> Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: what is the meaning of this useless code? Message-ID: <Pine.BSF.3.95.990111145306.395B-100000@current1.whistle.com> In-Reply-To: <Pine.LNX.4.04.9901111433440.18573-100000@feral-gw>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Jan 1999, Matthew Jacob wrote: > > if (resid > maxio) > resid = maxio; > > return getpbuf(); > } > > > why is resid being truyncaated and maxio being set when this has no > effect? I think resid was originally an agument to getpbuf but mechanical edits have turned it all into a NOP. Good catch.. However there is a related problem.. the maximum IO size allowed for a device is kept in the cdevsw entry, which is the WRONG place, because it cannot correctly reflect the case when there are two differnt devices with different limits on the same controller (e.g. two different drives or even two differend controllers on one driver). julian > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-hackers" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95.990111145306.395B-100000>