From owner-p4-projects@FreeBSD.ORG  Sat Jul 22 11:25:38 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6E57116A4E7; Sat, 22 Jul 2006 11:25:38 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 41A2916A4DE;
	Sat, 22 Jul 2006 11:25:38 +0000 (UTC)
	(envelope-from flag@oltrelinux.com)
Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9696243D49;
	Sat, 22 Jul 2006 11:25:37 +0000 (GMT)
	(envelope-from flag@oltrelinux.com)
Received: from krisma.oltrelinux.com (krisma [127.0.0.1])
	by mail.oltrelinux.com (Postfix) with ESMTP id DF38511AE76;
	Sat, 22 Jul 2006 13:25:33 +0200 (CEST)
Received: from host226-204.pool8717.interbusiness.it ([87.17.204.226])
	(SquirrelMail authenticated user flag@oltrelinux.com)
	by krisma.oltrelinux.com with HTTP;
	Sat, 22 Jul 2006 13:25:33 +0200 (CEST)
Message-ID: <24452.87.17.204.226.1153567533.squirrel@krisma.oltrelinux.com>
In-Reply-To: <44C13A13.7070307@samsco.org>
References: <200607211021.k6LALOmp039359@repoman.freebsd.org>
	<44C13A13.7070307@samsco.org>
Date: Sat, 22 Jul 2006 13:25:33 +0200 (CEST)
From: flag@oltrelinux.com
To: "Scott Long" <scottl@samsco.org>
User-Agent: SquirrelMail/1.4.4
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Paolo Pisati <piso@freebsd.org>
Subject: Re: PERFORCE change 102049 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Jul 2006 11:25:38 -0000

> Paolo Pisati wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=102049
>>
>> Change 102049 by piso@piso_longino on 2006/07/21 10:21:18
>>
>> 	Axe INTR_FAST.
>>
>> Affected files ...
>>
>> .. //depot/projects/soc2006/intr_filter/dev/aac/aac.c#4 edit
>> .. //depot/projects/soc2006/intr_filter/dev/adlink/adlink.c#4 edit
>> .. //depot/projects/soc2006/intr_filter/dev/cy/cy_isa.c#4 edit
>> .. //depot/projects/soc2006/intr_filter/dev/cy/cy_pci.c#5 edit
>>
>> Differences ...
>>
>> ==== //depot/projects/soc2006/intr_filter/dev/aac/aac.c#4 (text+ko) ====
>>
>> @@ -312,7 +312,7 @@
>>  		}
>>  	} else {
>>  		if (bus_setup_intr(sc->aac_dev, sc->aac_irq,
>> -				   INTR_FAST|INTR_TYPE_BIO,
>> +				   INTR_TYPE_BIO,
>>  				   aac_fast_intr, NULL,
>>  				   sc, &sc->aac_intr)) {
>>  			device_printf(sc->aac_dev,
>>
>
> AAC uses the same INTR_FAST + taskqueue scheme that if_em did.
>
> Scott

yep, but in this case i kept it like a filter_only + private taskqueue
driver, so no need to worry about MPSAFE.

P.