From owner-cvs-ports@FreeBSD.ORG Sat May 22 11:19:16 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id C71A51065674; Sat, 22 May 2010 11:19:16 +0000 (UTC) Date: Sat, 22 May 2010 11:19:16 +0000 From: Alexey Dokuchaev To: Max Brazhnikov Message-ID: <20100522111916.GB49597@FreeBSD.org> References: <200911291151.nATBpdsp044837@repoman.freebsd.org> <20100521170958.GA24679@FreeBSD.org> <4BF6EB8A.6020005@freebsd.org> <201005221405.42362.makc@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201005221405.42362.makc@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-all@freebsd.org, ports-committers@freebsd.org, Dmitry Marakasov , cvs-ports@freebsd.org, Rene Ladan , Dima Panov Subject: Re: cvs commit: ports/devel/cmake Makefile distinfo pkg-plist ports/devel/cmake-gui Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2010 11:19:16 -0000 On Sat, May 22, 2010 at 02:05:42PM +0400, Max Brazhnikov wrote: > On Fri, 21 May 2010 22:22:34 +0200, Rene Ladan wrote: > > > Yeah, I've also had to explicitly provide path to wxgtk2-2.8-config for > > > my CMake-based ports as well. Probably some sort of hack we used to > > > employ for sdl12-config is in order; creating symlink seems bad since > > > target might be something other than wxgtk2-2.8-config, leading to > > > potential conflicts. We have a long record of dealing with local > > > differences from the rest of the [GNU/OSS] world in a sane ways. :-) > > > > > I've sent a patch for this with ports/146805 > > With this patch cmake/wx-based ports will always try to build with wx-2.8 > when multiple wx ports are installed, disregarding what ports/user request. > > Wouldn't better to pass ${WX_CONFIG} for CMAKE_ARGS in bsd.wx.mk, as it does > already for CONFIGURE_ARGS? Hmm. Actually, that's pretty much what people do with their ports to hack around this problem (line from one of mine): CMAKE_ARGS= -DwxWidgets_CONFIG_EXECUTABLE="${WX_CONFIG}" Maybe we should just += this value to CMAKE_ARGS when appropriate (read: when USE_WX) and be done this it? ./danfe