From owner-cvs-sys Sat Jun 6 08:27:43 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA13169 for cvs-sys-outgoing; Sat, 6 Jun 1998 08:27:43 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA13158; Sat, 6 Jun 1998 08:27:32 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id PAA03389; Sat, 6 Jun 1998 15:27:31 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id RAA08953; Sat, 6 Jun 1998 17:26:51 +0200 (MET DST) Message-ID: <19980606172650.00314@follo.net> Date: Sat, 6 Jun 1998 17:26:50 +0200 From: Eivind Eklund To: Julian Elischer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sbin@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/fsck pass5.c src/sys/netinet ip_fw.c References: <199806052333.QAA05673@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199806052333.QAA05673@freefall.freebsd.org>; from Julian Elischer on Fri, Jun 05, 1998 at 04:33:28PM -0700 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Fri, Jun 05, 1998 at 04:33:28PM -0700, Julian Elischer wrote: > julian 1998/06/05 16:33:28 PDT > > Modified files: > sbin/fsck pass5.c > sys/netinet ip_fw.c > Log: > Reviewed by: Kirk Mckusick (mckusick@mckusick.com) > Submitted by: luoqi Chen > fix a type in fsck. > (also add a comment that got picked up by mistake but is worth adding) > > Revision Changes Path > 1.10 +1 -1 src/sbin/fsck/pass5.c > 1.86 +6 -1 src/sys/netinet/ip_fw.c For everybody's information: The comment referenced is in ip_fw.c, which at least confused _me_. Julian: Please Don't Do That. This makes commit logs & commit mail much harder to read, and means one has to go back and check the diffs instead of knowing what is in there at a later date.. Eivind.