From owner-freebsd-current@FreeBSD.ORG Thu Jul 23 15:11:57 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BF6E1065670 for ; Thu, 23 Jul 2009 15:11:57 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outA.internet-mail-service.net (outa.internet-mail-service.net [216.240.47.224]) by mx1.freebsd.org (Postfix) with ESMTP id 10BA08FC14 for ; Thu, 23 Jul 2009 15:11:56 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id 980FBB9857; Thu, 23 Jul 2009 08:12:13 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 49C1A2D6014; Thu, 23 Jul 2009 08:11:56 -0700 (PDT) Message-ID: <4A687DBE.5060200@elischer.org> Date: Thu, 23 Jul 2009 08:11:58 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: Jeff Laine , "M. Warner Losh" , FreeBSD Current References: <20090723132830.GA33539@free.bsd.loc> In-Reply-To: <20090723132830.GA33539@free.bsd.loc> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: ng_ipacct build error X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2009 15:11:57 -0000 Jeff Laine wrote: > Hello list! > > I have upgraded to BETA2 recently and decided to recompile net-mgmt/ng_ipacct port > (it was compiled in 7.2 so it's kernel module refused to load). > > But I stuck with this permanent stop error: > > > 4:49pm [/ports/net-mgmt/ng_ipacct]# make > ===> Vulnerability check disabled, database not found > ===> Found saved configuration for ng_ipacct-20061223 > ===> Extracting for ng_ipacct-20061223 > => MD5 Checksum OK for ng_ipacct-20061223.tar.gz. > => SHA256 Checksum OK for ng_ipacct-20061223.tar.gz. > ===> Patching for ng_ipacct-20061223 > ===> Applying FreeBSD patches for ng_ipacct-20061223 > ===> Configuring for ng_ipacct-20061223 > ===> Building for ng_ipacct-20061223 > ===> ng_ipacct (all) > Warning: Object directory not changed from original /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ng_ipacct > @ -> /usr/src/sys > machine -> /usr/src/sys/i386/include > :> opt_netgraph.h > cc -O2 -pipe -DMEM_USE_ZONE -fno-strict-aliasing -g -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ng_ipacct -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c ng_ipacct.c > ld -d -warn-common -r -d -o ng_ipacct.kld ng_ipacct.o > :> export_syms > awk -f /sys/conf/kmod_syms.awk ng_ipacct.kld export_syms | xargs -J% objcopy % ng_ipacct.kld > ld -Bshareable -d -warn-common -o ng_ipacct.ko ng_ipacct.kld > objcopy --strip-debug ng_ipacct.ko > ===> ipacctctl (all) > Warning: Object directory not changed from original /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ipacctctl > cc -O2 -pipe -DMEM_USE_ZONE -fno-strict-aliasing -g -Wall -Wformat -std=gnu99 -fstack-protector -c ipacctctl.c > ipacctctl.c:146: error: 'NG_PATHLEN' undeclared here (not in a function) > ipacctctl.c: In function 'ip_account_get_info': > ipacctctl.c:505: warning: unused variable 'path' > ipacctctl.c: In function 'ip_account_show': > ipacctctl.c:602: warning: unused variable 'path' > *** Error code 1 > > Stop in /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct/ipacctctl. > *** Error code 1 > > Stop in /tmp/usr/ports/net-mgmt/ng_ipacct/work/ng_ipacct. > *** Error code 1 > > Stop in /usr/ports/net-mgmt/ng_ipacct. > *** Error code 1 > > Stop in /usr/ports/net-mgmt/ng_ipacct. > > > > > Should I contact the maintainer or am I 'doing it wrong'? :) > > > TIA > > #ifndef BURN_BRIDGES /* don't use these - they will go away */ #define NG_TYPELEN (NG_TYPESIZ - 1) #define NG_HOOKLEN (NG_HOOKSIZ - 1) #define NG_NODELEN (NG_NODESIZ - 1) #define NG_PATHLEN (NG_PATHSIZ - 1) #define NG_CMDSTRLEN (NG_CMDSTRSIZ - 1) #endif they went away use NG_PATHSIZ (or NG_PATHSIZ-1 depending on what you ar edoing wih it).