Date: Fri, 7 Jan 2000 12:40:02 -0800 (PST) From: Ade Lovett <ade@lovett.com> To: freebsd-ports@FreeBSD.org Subject: Re: ports/15967: Update to BitchX IRC client port Message-ID: <200001072040.MAA17175@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/15967; it has been noted by GNATS.
From: Ade Lovett <ade@lovett.com>
To: calle.madestrand@norrgarden.se
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/15967: Update to BitchX IRC client port
Date: Fri, 7 Jan 2000 14:35:13 -0600
Analysis follows.. please don't take any of this the wrong way :)
On Fri, Jan 07, 2000 at 05:41:33PM +0100, calle.madestrand@norrgarden.se wrote:
>
> +# New ports collection makefile for: BitchX
Don't change this..
> +# Date created: 7 January 2000
> +# Whom: LoRd_CJ
> #
> +# $FreeBSD$
Or this..
> +.if defined(USE_GTK)
> +LIB_DEPENDS+= gtk12.2:${PORTSDIR}/x11-toolkits/gtk12 \
> + esd.2:${PORTSDIR}/audio/esound \
> + Imlib.5:${PORTSDIR}/graphics/imlib \
> + gnome.3:${PORTSDIR}/x11/gnomelibs
> +.endif
Since you're requiring GNOME libraries (does it really need them
for GTK support?, or is there GTK support, and then GNOME panel support
above that?), the USE_GTK should change to USE_GNOME or
(better, since Jeremy is planning on using these elsewhere), WITH_GNOME
> -MAN1= BitchX.1
> -MANCOMPRESSED= yes
> +GNU_CONFIGURE= yes
> +USE_GMAKE= yes
> +USE_AUTOCONF= yes
USE_AUTOCONF implies GNU_CONFIGURE, so you don't need that..
> + ${MKDIR} ${PREFIX}/lib/bx
> + ${MKDIR} ${PREFIX}/lib/bx/script
> + ${MKDIR} ${PREFIX}/lib/bx/plugins
> + ${MKDIR} ${PREFIX}/lib/bx/translation
The script and translation directories should be under share/bx
(see hier(7) for more details). I know the current port
puts things in lib/bx.. it's wrong :)
> +post-install:
> + ${CP} ${WRKSRC}/dll/*.so ${LOCALBASE}/lib/bx/plugins
> + ${CP} ${WRKSRC}/translation/* ${LOCALBASE}/lib/bx/translation
You want PREFIX here.. not LOCALBASE
> Only in /usr/home/cj/ports/bitchx/patches: patch-ab
> Only in /usr/ports/irc/bitchx/patches: patch-ad
> Only in /usr/ports/irc/bitchx/: patches.alpha
If files are to be added or removed, please mention them explicitly at
the top of the PR..
> +++ /usr/home/cj/ports/bitchx/pkg/PLIST Fri Jan 7 17:28:25 2000
> @@ -1,5 +1,64 @@
> +bin/gtkBitchX
Does gtkBitchX get installed if you don't specify support for it
when you're building? If not, then you'll need to do some PLIST
hackery..
> lib/bx/BitchX.help
> +lib/bx/BitchX.quit
> +lib/bx/BitchX.reasons
> +lib/bx/BitchX.ircnames
See above.. wserv and the plugins directory can stay under lib/
but the other bits and pieces should go under share/ ...
-aDe
--
Ade Lovett, Austin, TX.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001072040.MAA17175>