From owner-cvs-all Wed Jul 25 18: 6:42 2001 Delivered-To: cvs-all@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id C059937B405; Wed, 25 Jul 2001 18:06:32 -0700 (PDT) (envelope-from iedowse@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 26 Jul 2001 02:06:29 +0100 (BST) To: wpaul@FreeBSD.ORG Cc: ertr1013@student.uu.se, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c if_edreg.h if_edvar.h src/sys/i386/conf GENERIC In-Reply-To: Your message of "Wed, 25 Jul 2001 15:46:11 PDT." <20010725224611.3DD6137B405@hub.freebsd.org> Date: Thu, 26 Jul 2001 02:06:29 +0100 From: Ian Dowse Message-ID: <200107260206.aa73139@salmon.maths.tcd.ie> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20010725224611.3DD6137B405@hub.freebsd.org>, wpaul@FreeBSD.ORG writ es: >Gack. This is my fault. I disagree :-) This is my fault; the same problem happened when the miibus support was added to ed in -current, and I completely forgot to test a non-PCI kernel before committing to RELENG_4. I just MFC'd the one-liner with which Peter Wemm fixed this in -current last time. It makes dcphy dependent on pci, so it won't get compiled into a non-PCI kernel. This seems to fix the build for a non-PCI kernel I just tried; pnphy I think only has a header file in the pci directory so it's ok. >Unfortunately that doesn't help the miibus.ko module... unless I compile >the pnphy and dcphy drivers as part of the if_dc.ko module instead. Yeah, I don't fully understand what will happen here, but ed isn't a module in RELENG_4, so it's probably not critical. The miibus module will end up with references to pci functions, so I guess it just won't load on a non-PCI system. Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message