From owner-cvs-all@FreeBSD.ORG Wed May 12 20:45:37 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D5C816A4D0 for ; Wed, 12 May 2004 20:45:36 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E3F7A43D46 for ; Wed, 12 May 2004 20:45:35 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 86131 invoked by uid 1000); 13 May 2004 03:45:38 -0000 Date: Wed, 12 May 2004 20:45:37 -0700 (PDT) From: Nate Lawson To: Takanori Watanabe In-Reply-To: <200405130330.MAA11490@axe-inc.co.jp> Message-ID: <20040512203923.N86002@root.org> References: <200405130330.MAA11490@axe-inc.co.jp> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_ec.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2004 03:45:37 -0000 On Thu, 13 May 2004, Takanori Watanabe wrote: > In message <200405130317.i4D3H80t098184@repoman.freebsd.org>, Nate Lawson wrote > : > >njl 2004/05/12 20:17:08 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/acpica acpi_ec.c > > Log: > > Add support for retrieving _GLK in the ECDT probe. Now we no longer always > > use the global lock at the beginning of the ECDT probe. Instead, we use > > the handle from the ECDT to call _GLK. Also, unify the device description. > > I think accessing namespace in ECDT probe is incorrect way, because > it is expected to call before namespace is initialized. > > How do you think? Both NetBSD and FreeBSD call the ECDT probe routine between AcpiEnableSubsystem() and AcpiInitializeObjects(). At this point, the namespace has been initialized, we just haven't started running. You are correct that the ECDT can be probed even earlier, but it's useful to delay it to right before objects are evaluated. As far as problems this might cause, the only problem would be if _GLK did something crazy like accessing an EC opregion or depending on other objects to be executed first. This should never happen since it would break Windows XP also. -Nate