From owner-freebsd-arch@FreeBSD.ORG  Tue Jul  9 18:59:25 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id ECD143FB;
 Tue,  9 Jul 2013 18:59:25 +0000 (UTC)
 (envelope-from to.my.trociny@gmail.com)
Received: from mail-ea0-x231.google.com (mail-ea0-x231.google.com
 [IPv6:2a00:1450:4013:c01::231])
 by mx1.freebsd.org (Postfix) with ESMTP id 5B9C213AD;
 Tue,  9 Jul 2013 18:59:25 +0000 (UTC)
Received: by mail-ea0-f177.google.com with SMTP id j14so4044623eak.36
 for <multiple recipients>; Tue, 09 Jul 2013 11:59:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=K/cSb9hdiURvkwyE644sDeQmq7Mww0U0haGNN9tYkjQ=;
 b=m6b21uWlYehdRthqn9sA4vb8d6yTOJThYQCtmEZE60fTlWPgZuLFFbCoLQXuY2xuxj
 x8sR5G/8DjjzN8MV7UhgqhBl3inHVhRGfGHqPj9BUKKlGhdJ3Hn3m8/pHzPAt0+o+o3z
 TlV/6JVTiRXTbVd2H0aN2ii2RSWWMnbNVlMMZZpJo/HjTBBXl5tEr5USXwH1uLPBWKI7
 BeczcWErIgUmCKPJsEDTBNa6JT7fr4iIY6i+kqq1nSW+bR3Az8ebeOIlDkbDHg4Z45Hc
 joThbBYk98SKksIt0qZdeax2dxgxxP1SOW5yWZWh+08cVmfdX6FcwXSjMIvvdSwhuoCa
 AN/g==
X-Received: by 10.14.193.199 with SMTP id k47mr32126068een.83.1373396364357;
 Tue, 09 Jul 2013 11:59:24 -0700 (PDT)
Received: from localhost ([178.150.115.244])
 by mx.google.com with ESMTPSA id y1sm53338388eew.3.2013.07.09.11.59.22
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Tue, 09 Jul 2013 11:59:23 -0700 (PDT)
Sender: Mikolaj Golub <to.my.trociny@gmail.com>
Date: Tue, 9 Jul 2013 21:59:19 +0300
From: Mikolaj Golub <trociny@FreeBSD.org>
To: Robert Millan <rmh@freebsd.org>
Subject: Re: ABI change in libkvm (kvm_uread removal)
Message-ID: <20130709185846.GA19508@gmail.com>
References: <CAOfDtXPT-BQt9aqTNYHRK0XdiqKZsPnsO6s9vei=XCpyBvZZ6w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOfDtXPT-BQt9aqTNYHRK0XdiqKZsPnsO6s9vei=XCpyBvZZ6w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2013 18:59:26 -0000

On Tue, Jul 09, 2013 at 07:45:59PM +0200, Robert Millan wrote:
> Hi Mikolaj,
> 
> In 2011 you removed kvm_uread() from libkvm, in r227839.
> 
> Was this an intentional ABI change? I notice that kvm.h public header
> still has the declaration. Also, the soname was not bumped.

I think I thought then that kvm_uread() was for internal usage only
(it was used by libkvm only for reading process args and env via
procfs(5), no other consumers were found in base, no man page). Also
reading from procfs(5) did not look like libkvm job, so after the last
consumers had been removed, retiring it looked natural. I think I
overlooked the declaration in kvm.h and that I might break ABI,
otherwise it would have made me think more and ask other people if the
removal was ok.

> Should kvm.h and Makefile be adjusted to reflect the new ABI?

Suggestions how this should be fixed properly (if possible) are highly
appreciated. I will do what people suggest.

-- 
Mikolaj Golub