From owner-svn-src-all@FreeBSD.ORG Sun Nov 2 11:41:37 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4030106568C; Sun, 2 Nov 2008 11:41:37 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by mx1.freebsd.org (Postfix) with ESMTP id 0BC698FC20; Sun, 2 Nov 2008 11:41:36 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so1641273fgb.35 for ; Sun, 02 Nov 2008 03:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=VWeGzU9HsAqa92K61Oz7M7yxbAPe8w+q/Tol721QQys=; b=PAAMa8DkgFcfSp7R0d/IsdqZoZ2zWGZmawJBJ9H88O+TMfFrrvwzmJ4XhiP7HY2g8W SRotK8sCUuBS6QDPogrNQfT3HdqbkkUKEUojwUs38qFsrZlmxwgrQYozUsYsB5OVv/Rc kZs0IL0vkJPAhV4UX2NaGuYTrA1Bb0cfeLfXE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Ku878+vBcCw2dBOjFKyfY8pDqxjDN+rNBERNgOsyKxbHbAEe29truGOFd18inboSow neSbO8N15GMXkUL8Hd/stCvMArNXlfLZ98CQFvrOh2HsTokmpQt/MLvITlYquDBOosMJ qatud9ONJZhaCJOBj8tTi+YIS5eVpx40/wJIY= Received: by 10.103.214.13 with SMTP id r13mr6531098muq.4.1225626094972; Sun, 02 Nov 2008 03:41:34 -0800 (PST) Received: by 10.103.239.14 with HTTP; Sun, 2 Nov 2008 03:41:34 -0800 (PST) Message-ID: <3bbf2fe10811020341y4ae59546jb073b42945356b8c@mail.gmail.com> Date: Sun, 2 Nov 2008 12:41:34 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Bjoern A. Zeeb" In-Reply-To: <20081102103546.S41609@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811021015.mA2AFgim036178@svn.freebsd.org> <20081102102108.B41609@maildrop.int.zabbadoz.net> <3bbf2fe10811020234n14f554b3ld60eca8527e2647b@mail.gmail.com> <20081102103546.S41609@maildrop.int.zabbadoz.net> X-Google-Sender-Auth: e6415fbfa33d815b Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184554 - in head/sys: geom/journal gnu/fs/ext2fs kern nfsclient sys ufs/ffs ufs/ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2008 11:41:37 -0000 2008/11/2, Bjoern A. Zeeb : > On Sun, 2 Nov 2008, Attilio Rao wrote: > > > > > > > > > > > This patch modifies VFS ABI and breaks KPI for vfs_busy() so manpages > and > > > > __FreeBSD_version will be modified accordingly. > > > > > > > > > > > > > > So why didn't you update __FreeBSD_version with the same commit that > > > changed the KPI? > > > > > > > I just prefer to split "managing" stuff from the tecnical content. > > > > Well we have changesets with SVN and looking at the FreeBSD version > bump I have no idea what changeset(s) it's actually refering to. I > think we should exploit the features SVN gives us and either do it in > the same commit (if possible because it's a single commit) or > reference the relevant SVN revisions in the bump in the future so that > the xPI change and the bump can be easily linked together. I totally didn't take into consideration that. Thanks for pointing out, it is a good point, and will try to follow in next KPI modifies. Attilio -- Peace can only be achieved by understanding - A. Einstein