From owner-cvs-all@FreeBSD.ORG  Sun Nov 30 21:41:47 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 64E8C16A4CE; Sun, 30 Nov 2003 21:41:47 -0800 (PST)
Received: from axe-inc.co.jp (axegw.axe-inc.co.jp [61.199.217.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 76BD543F85; Sun, 30 Nov 2003 21:41:45 -0800 (PST)
	(envelope-from takawata@axe-inc.co.jp)
Received: from localhost (localhost [127.0.0.1])
	by axe-inc.co.jp (8.9.3+3.2W/3.7W) with SMTP id OAA26027;
	Mon, 1 Dec 2003 14:41:34 +0900 (JST)
Message-Id: <200312010541.OAA26027@axe-inc.co.jp>
X-Authentication-Warning: axegw.axe-inc.co.jp: localhost [127.0.0.1] didn't
	use HELO protocol
To: Nate Lawson <nate@root.org>
In-reply-to: Your message of "Sun, 30 Nov 2003 20:19:19 PST."
             <20031130201755.K11560@root.org>
Date: Mon, 01 Dec 2003 14:41:34 +0900
From: Takanori Watanabe <takawata@axe-inc.co.jp>
cc: akiyama@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb ubsa.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2003 05:41:47 -0000

In message <20031130201755.K11560@root.org>, Nate Lawson wrote:
>On Sun, 30 Nov 2003, Shunsuke Akiyama wrote:
>>   Modified files:        (Branch: RELENG_4)
>>     sys/dev/usb          ubsa.c
>>   Log:
>>   MFC: revision 1.11
>>
>>   Apply some fixups in the driver_t's.
>>
>>   Revision  Changes    Path
>>   1.2.2.2   +1 -1      src/sys/dev/usb/ubsa.c
>>
>> --- src/sys/dev/usb/ubsa.c:1.2.2.1	Wed Dec 11 12:54:47 2002
>> +++ src/sys/dev/usb/ubsa.c	Sun Nov 30 04:53:40 2003
>> @@ -237,7 +237,7 @@
>>  };
>>
>>  Static driver_t ubsa_driver = {
>> -	"ubsa",
>> +	"ucom",
>>  	ubsa_methods,
>>  	sizeof (struct ubsa_softc)
>>  };
>>
>
>Are you sure this is the direction you want to go?  The driver is called
>ubsa and has a man page called ubsa.4.  Why make it inaccurate?

This is correct. Module name itself is ubsa, but this imprements
a kind of "ucom" interface and it shares ucom_devclass with other
ucom drivers. Driver name should be same in all devclass, or the unit number 
management will got wrong.
Just like both host-pci bus bridge and pci-pci bus bridge has
same name "pcib".