From owner-freebsd-current@FreeBSD.ORG Tue Sep 21 20:23:30 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A531516A4CE; Tue, 21 Sep 2004 20:23:30 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E74A43D46; Tue, 21 Sep 2004 20:23:30 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net [67.127.84.57]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i8LKN3Dl008120; Tue, 21 Sep 2004 13:23:05 -0700 Message-ID: <41508D8F.70002@root.org> Date: Tue, 21 Sep 2004 13:22:39 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <41421D6A.8070805@cronyx.ru> <41505663.40407@cronyx.ru> <4150607D.3020900@root.org> <200409211441.42325.jhb@FreeBSD.org> In-Reply-To: <200409211441.42325.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: FreeBSD Current cc: Ian Freislich cc: Roman Kurakin Subject: Re: mp_machdep.c (was Re: [Fwd: Re: Bug reports requested - acpi]) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 20:23:30 -0000 John Baldwin wrote: > On Tuesday 21 September 2004 01:10 pm, Nate Lawson wrote: >>A quick "no" vote from me until this is really understood. I think the >>real problem is an interference between the pmap for the AP trampoline >>and the acpi wake code (sys/i386/acpica/acpi_wakeup.c). The address you >>gave (0x9f000) is right before the base address we use for the wakeup >>code (0xa0000). As I woke up this morning, I was wondering if this >>could be the issue. An easy way to test is to disable the call to >>acpi_install_wakeup_handler() in sys/i386/acpica/acpi_machdep.c and see >>if this alone fixes the problem. >> >>If I'm wrong, feel free to commit your patch. >> >>P.S. Spaces instead of tabs in your diff. > > Umm, 0xa0000 is the start of Video RAM, so I sure hope the ACPI wake code > doesn't try to write code into Video memory. The pmap_invalidate_page is > certainly needed. This call to alloc the memory seems to say 0xa0000 is the first valid start address: if (bus_dma_tag_create(/* parent */ NULL, /* alignment */ 2, 0, /* lowaddr below 1MB */ 0x9ffff, /* highaddr */ BUS_SPACE_MAXADDR, NULL, NULL, PAGE_SIZE, 1, PAGE_SIZE, 0, busdma_lock_mutex, &Giant, &acpi_waketag) != 0) In any case, you're right about needing to invalidate the mapping after creating it so feel free to commit. Do we also need this after pmap_enter() in acpi_sleep_machdep() (i386/acpica/acpi_wakeup.c)? -- Nate