From owner-cvs-all@FreeBSD.ORG  Thu Sep 25 11:51:10 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E4A9516A4B3; Thu, 25 Sep 2003 11:51:10 -0700 (PDT)
Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E027F43FFB; Thu, 25 Sep 2003 11:51:07 -0700 (PDT)
	(envelope-from kolmeronline@comcast.net)
Received: from 204.127.197.111 ([204.127.197.111])
          by comcast.net (rwcrmhc13) with SMTP
          id <2003092518510701500l6ntte>; Thu, 25 Sep 2003 18:51:07 +0000
Received: from [12.246.2.55] by 204.127.197.111;
	Thu, 25 Sep 2003 18:51:07 +0000
From: kolmeronline@comcast.net
To: Maxime Henrion <mux@freebsd.org>
Date: Thu, 25 Sep 2003 18:51:07 +0000
X-Mailer: AT&T Message Center Version 1 (Sep 12 2003)
X-Authenticated-Sender: a29sbWVyb25saW5lQGNvbWNhc3QubmV0
Message-Id: <20030925185107.E027F43FFB@mx1.FreeBSD.org>
cc: doc-committers@freebsd.org
cc: Ken Smith <kensmith@freebsd.org>
cc: cvs-doc@freebsd.org
cc: cvs-all@freebsd.org
cc: Josef El-Rayes <j.el-rayes@daemon.li>
Subject: Re: cvs commit:
	doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2003 18:51:11 -0000



Please do not email us!!!!!!!!!!!!!!!!!!!!!!!
> Josef El-Rayes wrote:
> > Ken Smith <kensmith@FreeBSD.org> wrote:
> > > - "whitespace change" that coverts existing driver example code
> > > to be style(9) compliant, matching format of new driver code
> > 
> > for me this is strange, i always thought that we do not do patches which
> > do whitespace changes only - which does make the repository bigger
> > without any real benefit.
> 
> Not really - what is most important is to not mix functional changes and
> whitespace changes touching different parts of the code in a single commit
> since it makes the diff much harder to read.  Bearing this in mind, when
> you want a file to be style(9) compliant, you sometimes have to bite the
> bullet and commit whitespace changes only.  I usually do this before
> heavily modifying a file, making it style(9) compliant before doing
> anything else.  This way, I'm not tempted to fix style(9) bugs when doing
> functional changes and I keep the functional changes commit clean.
> 
> Cheers,
> Maxime
> _______________________________________________
> cvs-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
>